Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mpox as the default monkeypox URL prefix #712

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

jameshadfield
Copy link
Member

@jameshadfield jameshadfield commented Sep 25, 2023

All 3 current /mpox datasets (/mpox/lineage-B.1, /mpox/clade-IIb, /mpox/all-clades) are added to the manifest (and thus Auspice's dropdowns), with the last one set as the default. The card on the main splash page is switched to /mpox.

Context (slack): https://bedfordlab.slack.com/archives/C03G8HQEV18/p1695508115055009

The original /monkeypox/* URLs are left unchanged however we can remove these and add redirects instead if we wish to. Steps to do so:

  • Removing monkeypox from the (committed) manifest JSON will remove it from the auspice sidebar dropdowns and stop the ability for default URL redirects such as 'monkeypox' → 'monkeypox/hmpxv1'
  • Removing /monkeypox from app.js will stop nextstrain.org/monkeypox URLs working at all (they'll 404)
  • Redirects to go from /monkeypox URLs to /mpox ones should be added in ./src/redirects.js. All the dataset names have changed (i.e. it's not just /monkeypox/mpox/) so we should add explicit redirects for all the old URLs.

@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-manifest-m-n73mf6 September 25, 2023 00:58 Inactive
@corneliusroemer
Copy link
Member

Looks good, you chose to default to all-clade which is fine I guess, though most mpox these days is clade-IIb so we might also want to choose that. But this decision not blocking and easily changed later.

@jameshadfield
Copy link
Member Author

most mpox these days is clade-IIb so we might also want to choose that

Force-pushed to change the default to clade-IIb

@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-manifest-m-n73mf6 September 25, 2023 01:30 Inactive
@corneliusroemer
Copy link
Member

Test work! Let's merge :)

But shall we also rename the tile from monkeypox to mpox?

image

https://nextstrain-s-manifest-m-n73mf6.herokuapp.com/mpox/all-clades

The original /monkeypox/* URLs are left unchanged however we can remove
these and add redirects instead if we wish to. Card names are updated
to 'mpox' as per WHO recommendations
<https://www.who.int/news/item/28-11-2022-who-recommends-new-name-for-monkeypox-disease>

Context (slack): <https://bedfordlab.slack.com/archives/C03G8HQEV18/p1695508115055009>
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-manifest-m-n73mf6 September 25, 2023 02:03 Inactive
@jameshadfield
Copy link
Member Author

Redirects added, as per @corneliusroemer's suggestion.

/monkeypox/mpxv → /mpox/all-clades
/monkeypox/hmpxv1 → /mpox/clade-IIb
/monkeypox/hmpxv1/big → /mpox/lineage-B.1

While the monkeypox option no longer exists in the auspice sidebar, valid URLs will still work, e.g. /monkeypox/hmpxv1/2022-09-04

@jameshadfield jameshadfield merged commit 2e806a5 into master Sep 25, 2023
4 checks passed
@jameshadfield jameshadfield deleted the manifest/mpox branch September 25, 2023 02:16
This was referenced Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants