Add Nextclade section on splash #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genehack
approved these changes
Jun 7, 2024
victorlin
force-pushed
the
victorlin/use-showcase-on-splash
branch
4 times, most recently
from
7b99c6a
to
eefb79e
Compare
victorlin
force-pushed
the
victorlin/add-nextclade-section-on-splash
branch
from
606598d
to
c423a51
Compare
victorlin
force-pushed
the
victorlin/use-showcase-on-splash
branch
2 times, most recently
from
66b395f
to
e6fa8aa
Compare
genehack
approved these changes
Jun 10, 2024
victorlin
force-pushed
the
victorlin/add-nextclade-section-on-splash
branch
from
c423a51
to
9ae59a6
Compare
victorlin
force-pushed
the
victorlin/use-showcase-on-splash
branch
from
e6fa8aa
to
a19026e
Compare
victorlin
force-pushed
the
victorlin/add-nextclade-section-on-splash
branch
from
9ae59a6
to
9dd6249
Compare
Now that sections aren't required to have preview cards, a section for Nextclade without any cards can visually fit in. Place it as the 2nd section both due to its importance and because the abstract length is similar to SARS-CoV-2's, rendering nicely in the 2-column format.
victorlin
force-pushed
the
victorlin/add-nextclade-section-on-splash
branch
from
9dd6249
to
3878dde
Compare
This was referenced Jun 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
Now that sections aren't required to have preview cards, a section for Nextclade without any cards can visually fit in.
Related issue(s)
Open questions
Where should the new Nextclade section be placed? I added it to the end but it should probably go elsewhere.doneChecklist
Check if changes affect the resource index JSON revision