Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap splash tiles to use viz screenshots #914

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Jun 12, 2024

preview (also see final form of splash in #922)

image

This commit swaps the tiles used on the splash page from the previous doctored electron micrographs to be simple screenshots of the pages / pathogens that are linked to. This has two advantages:

  1. It's super simple and no longer requires sourcing a copyright-free image and doctoring it in LunaPic
  2. It's a more up front, more transparent window into what you get when you click on a tile

I used tree vs map depending on spatial / epi patterns. For pathogens like WNV and Ebola, the map is meaningful and interesting, while for things like H3N2, it's less relevant. I generally tried to stick close to the content that's directly linked and not update coloring, etc..., but I made a couple of exceptions for visual interest.

Checklist

@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-trvrb-sema-uhwlnj June 12, 2024 21:55 Inactive
@jameshadfield
Copy link
Member

jameshadfield commented Jun 12, 2024

Nice! I was a big fan of the styled cards in the early days but they didn't scale well in multiple senses of the word. This should give us a lot more scope to implement new functionality in future.

Way beyond this PR, if we end up wanting similar tiles in an automated fashion (/groups/x etc) it's possible to automate their creation using a similar approach to how we converted narratives to PDFs

@jameshadfield
Copy link
Member

Parent PR (LHS) vs this PR (RHS). Colour matching between tiles and rainbow Nextstrain title is nice.

image

Base automatically changed from victorlin/use-showcase-on-splash to master June 13, 2024 17:46
@victorlin
Copy link
Member

Rebasing this onto latest master

@victorlin victorlin temporarily deployed to nextstrain-s-trvrb-sema-uhwlnj June 13, 2024 18:25 Inactive
@victorlin
Copy link
Member

victorlin commented Jun 13, 2024

I added a few more things to the PR description to consider if pursuing this direction. Feel free to tweak!

@victorlin
Copy link
Member

Rebasing to resolve merge conflicts

@victorlin victorlin temporarily deployed to nextstrain-s-trvrb-sema-uhwlnj June 14, 2024 21:55 Inactive
This was referenced Jun 14, 2024
@victorlin
Copy link
Member

Bundling these changes into #922 (aeffbe2)

@victorlin victorlin closed this Jun 22, 2024
@victorlin victorlin deleted the trvrb/semantic-tiles branch June 22, 2024 00:00
victorlin and others added 5 commits June 24, 2024 16:39
This commit swaps the tiles used on the splash page from the previous doctored electron micrographs to be simple screenshots of the pages / pathogens that are linked to. This has two advantages:
1. It's super simple and no longer requires sourcing a copyright-free image and doctoring it in LunaPic
2. It's a more up front, more transparent window into what you get when you click on a tile

I used tree vs map depending on spatial / epi patterns. For pathogens like WNV and Ebola, the map is meaningful and interesting, while for things like H3N2, it's less relevant. I generally tried to stick close to the content that's directly linked and not update coloring, etc..., but I made a couple of exceptions for visual interest.
The swap makes less sense here since clicking does not immediately go to
the visualization.

However, this is the last place that the electron micrographs are used.
Removing them from here removes the need to maintain two separate images
per pathogen and removes the need to conditionally include image credit
in the footer.

Screenshots added for pathogens that weren't included in splash.
@victorlin victorlin restored the trvrb/semantic-tiles branch June 25, 2024 00:15
@victorlin
Copy link
Member

Actually there's enough going on in the screenshot swap that I'm going to put those changes back into this PR. This should make it easier to review each batch of related commits.

@victorlin victorlin reopened this Jun 25, 2024
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-trvrb-sema-mukyri June 25, 2024 00:15 Inactive
@victorlin victorlin temporarily deployed to nextstrain-s-trvrb-sema-mukyri June 25, 2024 00:16 Inactive
@victorlin victorlin changed the base branch from master to victorlin/showcase-refactor June 25, 2024 00:16
@victorlin victorlin marked this pull request as ready for review June 25, 2024 00:22
static-site/README.md Show resolved Hide resolved
Base automatically changed from victorlin/showcase-refactor to master June 27, 2024 18:07
@victorlin victorlin merged commit d9db24a into master Jun 27, 2024
7 checks passed
@victorlin victorlin deleted the trvrb/semantic-tiles branch June 27, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants