Reorganize files related to splash #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorlin
force-pushed
the
victorlin/reorganize-splash
branch
from
5eec50f
to
d194760
Compare
victorlin
force-pushed
the
victorlin/reorganize-splash
branch
from
d194760
to
8f022ab
Compare
5 tasks
| @@ -19,6 +18,21 @@ const NavContainer = styled.div` | |||
| left: 0px; | |||
| z-index: 1001; | |||
| transition: left .3s ease-out; | |||
|
|
|||
| // TODO: Put this component in a container which sets these styles for all pages. | |||
There was a problem hiding this comment.
[for consideration] You could use a global CSS class (here are the global CSS imports we currently use) or a CSS module which both pages import.
There was a problem hiding this comment.
I haven't actually tried so this could get complicated, but I would rather follow through here and create a common page-level container component to be used across all pages so that there's not so many different ones with varying styles and navbar + footer logos added separately.
Or maybe the split is intentional – if that's the case, this TODO doesn't really make sense and I'll consider using the global CSS class here.
There was a problem hiding this comment.
Moved this change to #958
victorlin
force-pushed
the
victorlin/reorganize-splash
branch
from
bc353f1
to
74a3882
Compare
joverlee521
approved these changes
Jul 29, 2024
That is the only usage. Also add a note on where it was copied from.
Components in this file are not used on Splash and should be directly under src/components.
These are not used on Splash and should be directly under src/components.
This sets an unknown type for all YAML imports, to be set later.
Part of a larger effort to add types in the codebase.
Part of a larger effort to move away from class components in the codebase.
Part of a larger effort to add types in the codebase.
victorlin
force-pushed
the
victorlin/reorganize-splash
branch
from
74a3882
to
fa40d2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preview
Description of proposed changes
Lots of small changes. See commit messages.
Related issue(s)
Checklist
/,/groups/blab