Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styles for blog pages #970

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Fix styles for blog pages #970

merged 2 commits into from
Jul 31, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jul 31, 2024

Follow-up to #958 which caused regressions on blog pages. Noted by @trvrb on Slack.

Checklist

This was never necessary since the blog page doesn't follow Bootstrap
layout, hence the width override removed in this commit. "Update to
Bootstrap v4" (5948261) made this conflict more apparent.
Noticeable on the blog pages where the navbar is bounded by the narrow
sidebar, this was broken by "Make navbar width consistent with splash
and generic page containers" (5377226) which replaced "max-width" with
"width". Changing back to "max-width" restores original behavior.
@victorlin victorlin self-assigned this Jul 31, 2024
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-victorlin--tgjdfb July 31, 2024 20:04 Inactive
@victorlin victorlin marked this pull request as ready for review July 31, 2024 20:11
@victorlin victorlin merged commit e09a6ba into master Jul 31, 2024
7 checks passed
@victorlin victorlin deleted the victorlin/fix-blog-styles branch July 31, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants