-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page for listing Group members #973
Commits on Aug 6, 2024
-
Simplifying conditionals in preparation for adding another dynamic route for a group members page.
Configuration menu - View commit details
-
Copy full SHA for a8a671f - Browse repository at this point
Copy the full SHA a8a671fView commit details -
I was looking into tackling the TODO comment for the location prop¹ in the groups JS routing. The location prop was being passed around to be used in the NavBar component, but the use of it was removed in a recent refactoring.² So just remove all of the unused `location` props for the `NavBar` and the `GenericPage` components. ¹ <https://github.com/nextstrain/nextstrain.org/blob/1aeb1e499b9f25d9a918465fd3450fca51f40a2d/static-site/pages/groups/%5B...groupName%5D.jsx#L22> ² <ac12e32>
Configuration menu - View commit details
-
Copy full SHA for 6ca011a - Browse repository at this point
Copy the full SHA 6ca011aView commit details -
Add missing OPTIONS methods for Groups membership routes
The OPTIONS method was included in the RESTful API docs¹ for the new Groups membership routes, but were not added to the routes themselves. I will be using this in future changes to check user permissions for viewing and editing Group members. ¹ <84a7374#diff-676fb03989c04d3661eac5e82cb55fc6a9f43df70bd94565535ba509e12f0c64>
Configuration menu - View commit details
-
Copy full SHA for dfa17f8 - Browse repository at this point
Copy the full SHA dfa17f8View commit details -
Add page for listing Group members
The new page is available at `groups/<groupName>/settings/members`. I chose to use the same URL as the API so that we don't have to take up another namespace (e.g. `groups/<groupName>/members`). The main Group page will only link out to the members page if the current user is authorized to list Group members. The members list only displays the most privileged role for each member to keep the display simple. It assumes the group roles API returns the roles in the order from least to most privileged.
Configuration menu - View commit details
-
Copy full SHA for be4bb7c - Browse repository at this point
Copy the full SHA be4bb7cView commit details -
- remove unused `props` - remove unnecessary semicolons
Configuration menu - View commit details
-
Copy full SHA for 7307ef0 - Browse repository at this point
Copy the full SHA 7307ef0View commit details
Commits on Aug 9, 2024
-
group-members-page: Prettify displayed roles
Based on feedback from @victorlin in review <#973 (comment)>
Configuration menu - View commit details
-
Copy full SHA for a2c9dc4 - Browse repository at this point
Copy the full SHA a2c9dc4View commit details -
group-members-page: Add styling container for MembersTable
Based on feedback from @victorlin in review <#973 (comment)>
Configuration menu - View commit details
-
Copy full SHA for fe814ee - Browse repository at this point
Copy the full SHA fe814eeView commit details
Commits on Aug 13, 2024
-
Use switch statement in Groups JS routing
Based on feedback from @genehack <#973 (comment)>
Configuration menu - View commit details
-
Copy full SHA for 195aa4f - Browse repository at this point
Copy the full SHA 195aa4fView commit details
Commits on Aug 14, 2024
-
group-members-page: Display all roles for a Group member
Based on feedback from @tsibley <#973 (comment)>
Configuration menu - View commit details
-
Copy full SHA for 027910d - Browse repository at this point
Copy the full SHA 027910dView commit details