Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page for listing Group members #973

Merged
merged 9 commits into from
Aug 15, 2024
Merged

Add page for listing Group members #973

merged 9 commits into from
Aug 15, 2024

Commits on Aug 6, 2024

  1. Refactor Groups JS routing

    Simplifying conditionals in preparation for adding another dynamic route
    for a group members page.
    joverlee521 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a8a671f View commit details
    Browse the repository at this point in the history
  2. Remove unused location props

    I was looking into tackling the TODO comment for the location prop¹ in
    the groups JS routing. The location prop was being passed around to be
    used in the NavBar component, but the use of it was removed in a
    recent refactoring.² So just remove all of the unused `location` props
    for the `NavBar` and the `GenericPage` components.
    
    ¹ <https://github.com/nextstrain/nextstrain.org/blob/1aeb1e499b9f25d9a918465fd3450fca51f40a2d/static-site/pages/groups/%5B...groupName%5D.jsx#L22>
    ² <ac12e32>
    joverlee521 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    6ca011a View commit details
    Browse the repository at this point in the history
  3. Add missing OPTIONS methods for Groups membership routes

    The OPTIONS method was included in the RESTful API docs¹ for the new
    Groups membership routes, but were not added to the routes themselves.
    
    I will be using this in future changes to check user permissions for
    viewing and editing Group members.
    
    ¹ <84a7374#diff-676fb03989c04d3661eac5e82cb55fc6a9f43df70bd94565535ba509e12f0c64>
    joverlee521 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    dfa17f8 View commit details
    Browse the repository at this point in the history
  4. Add page for listing Group members

    The new page is available at `groups/<groupName>/settings/members`.
    I chose to use the same URL as the API so that we don't have to take
    up another namespace (e.g. `groups/<groupName>/members`). The main Group
    page will only link out to the members page if the current user is
    authorized to list Group members.
    
    The members list only displays the most privileged role for each member
    to keep the display simple. It assumes the group roles API returns the
    roles in the order from least to most privileged.
    joverlee521 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    be4bb7c View commit details
    Browse the repository at this point in the history
  5. Fix up linter errors

    - remove unused `props`
    - remove unnecessary semicolons
    joverlee521 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7307ef0 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. group-members-page: Prettify displayed roles

    Based on feedback from @victorlin in review
    <#973 (comment)>
    joverlee521 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a2c9dc4 View commit details
    Browse the repository at this point in the history
  2. group-members-page: Add styling container for MembersTable

    Based on feedback from @victorlin in review
    <#973 (comment)>
    joverlee521 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    fe814ee View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Use switch statement in Groups JS routing

    Based on feedback from @genehack
    <#973 (comment)>
    joverlee521 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    195aa4f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    027910d View commit details
    Browse the repository at this point in the history