Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use production config.json in index-resources GH Action #983

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Always use production config.json in index-resources GH Action #983

merged 3 commits into from
Aug 14, 2024

Commits on Aug 13, 2024

  1. Update docs/resource-collection 

    Add reminder to also update revision number in `env/testing/config.json`
    @joverlee521
    joverlee521 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8a8ff00 View commit details
    Browse the repository at this point in the history

  2. Always use production config.json in index-resources GH Action 

    Ensures that the index-resource workflow always uses the production
config as our Heroku apps default to NODE_ENV=production.¹

¹ <https://docs.nextstrain.org/projects/nextstrain-dot-org/en/latest/infrastructure.html#environment-or-config-variables>
    @joverlee521
    joverlee521 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    255b868 View commit details
    Browse the repository at this point in the history

  3. CI: Check for matching RESOURCE_INDEX 

    Based on feedback from @jameshadfield
<#983 (comment)>

Ensure that the testing and production configs have matching
RESOURCE_INDEX so that we don't accidentally upload an expected
resource index version.
    @joverlee521
    joverlee521 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9d45dd0 View commit details
    Browse the repository at this point in the history