Auto-prepend / to tile URLs
#996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
nextstrain-s-victorlin--510ohe
Previously, the code assumed that all URLs started with `/` and was noted in featured-analyses.yaml. However, there was nothing to check this. A `/` is perfectly valid for everything except for the source check, which silently assumes everything that doesn't start with `/` is maintained by Nextstrain. This is a bad assumption. The source check could either (1) be updated to work with the error or (2) throw a runtime error. I chose to go with (1) to make things easier when updating featured analyses.
victorlin
force-pushed
the
victorlin/allow-url-without-first-slash
branch
from
ef015c0
to
577a343
Compare
genehack
approved these changes
Aug 23, 2024
jameshadfield
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Previously, the code assumed that all URLs started with
/and was noted in featured-analyses.yaml. However, there was nothing to check this. A/is perfectly valid for everything except for the source check, which silently assumes everything that doesn't start with/is maintained by Nextstrain. This is a bad assumption.The source check could either (1) be updated to work with the error or (2) throw a runtime error. I chose to go with (1) to make things easier when updating featured analyses.
Related issue(s)
Follow-up to #993 (comment)
Checklist