Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add biome for lint and format CSS and JS #76

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

ar4s
Copy link
Contributor

@ar4s ar4s commented Oct 5, 2024

  • fix errors
  • add job to CI
  • update README.md

@ar4s ar4s force-pushed the chore/tool-biome branch from ed93a5e to 3abe8af Compare October 5, 2024 15:30
@ar4s ar4s force-pushed the chore/tool-biome branch 2 times, most recently from bb846c5 to 18514b6 Compare October 5, 2024 15:35
@ar4s ar4s mentioned this pull request Oct 5, 2024
@ar4s ar4s force-pushed the chore/tool-biome branch 4 times, most recently from bab0113 to 067bd04 Compare October 6, 2024 17:33
@ar4s ar4s force-pushed the chore/tool-biome branch from 067bd04 to 2be6590 Compare October 6, 2024 17:35
@ar4s ar4s marked this pull request as ready for review October 6, 2024 17:36
@ar4s ar4s mentioned this pull request Oct 6, 2024
3 tasks
@nfoert
Copy link
Owner

nfoert commented Oct 7, 2024

Thanks for implementing this @ar4s! I was just playing around with it and it seems to be very performant.
You said in #73 that you were having trouble with a lot of errors, I think this should wait to get merged until all of the .js files can be checked with biome
Would it be helpful if I worked on fixing some of the JavaScript files?

@ar4s
Copy link
Contributor Author

ar4s commented Oct 7, 2024

Would it be helpful if I worked on fixing some of the JavaScript files?

Sure :) you know better the project and features and biome's errors are convinient and readable. You can grab editor and I take care of the smallest ones :)

@nfoert
Copy link
Owner

nfoert commented Oct 7, 2024

You can grab editor and I take care of the smallest ones :)

Okay, will do!

"linter": {
"rules": {
"style": {
"noVar": "off"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I set noVar to off because it was wanting any globaly declared variable to be changed to let or const, however, global variables are required in several places in this project

These are meant to be kept minified to take up less storage space when they're downloaded from the server and to reduce load time
@nfoert
Copy link
Owner

nfoert commented Oct 8, 2024

@ar4s, I also set to ignore any *.min.js files so these can stay minified, in case later we're allowing many more directories of scripts to be linted and formatted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants