-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial auto-generation support for streaming APIs #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amehra-ni
changed the title
Users/amehra/auto generate api
Add initial auto-generation support for streaming APIs
Oct 28, 2024
doshirohan
reviewed
Nov 4, 2024
doshirohan
reviewed
Nov 4, 2024
…com/ni/grpc-device into users/amehra/auto-generate-api
doshirohan
reviewed
Nov 5, 2024
doshirohan
reviewed
Nov 6, 2024
…mehra/auto-generate-api
amehra-ni
requested review from
reckenro,
astarche and
maxxboehme
as code owners
November 7, 2024 11:25
maxxboehme
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both grpc and sideband servers runs fine.
Can you add more details about the testing done since no automated testing was added in the PR.
astarche
reviewed
Nov 7, 2024
astarche
reviewed
Nov 7, 2024
astarche
reviewed
Nov 7, 2024
maxxboehme
requested changes
Nov 7, 2024
maxxboehme
requested changes
Nov 8, 2024
maxxboehme
requested changes
Nov 8, 2024
maxxboehme
approved these changes
Nov 11, 2024
doshirohan
reviewed
Nov 11, 2024
reckenro
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds initial support for auto-generation of streaming APIs. This might not be complete, but we will be iteratively covering cases in follow-ups.
Why should this Pull Request be merged?
Struct Generation: First, generate the necessary structs for the streaming API.
Moniker Functions: Next, generate the Moniker functions required for streaming.
Function Generation: Finally, generate the streaming functions themselves.
What testing has been done?
Both grpc-server and sideband server runs fine. I'm able to use the client code and call the server with all the new streaming APIs and talk with the VI.