Add "When" attribute to start_trigger.py #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeborahOoi96
requested review from
zhindes,
maxxboehme and
bkeryan
as code owners
DeborahOoi96
commented
Feb 1, 2024
bkeryan
reviewed
Feb 1, 2024
src/codegen/templates/_task_modules/triggering/start_trigger.py.mako
Outdated
Show resolved
Hide resolved
bkeryan
requested changes
Feb 1, 2024
bkeryan
approved these changes
Feb 2, 2024
bkeryan
reviewed
Feb 2, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Adds the
whenattribute to start_trigger.py. This will enable users to get and set the when attribute when using Start Trigger.Implemented
GetTrigAttributeTimestampandSetTrigAttributeTimestampas it seems start_trig_trig_when uses these functions when gettingwhenattribute.Also removed
_lib_timefrom interpreters as this causes errors in unit testing.Why should this Pull Request be merged?
Noticed this was not available when I was working on unit test for adding CfgTimeStartTrig function.
What testing has been done?
Manual validation that exported files are as expected.