Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular column placeholder #1966

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Angular column placeholder #1966

merged 5 commits into from
Mar 28, 2024

Conversation

mollykreis
Copy link
Contributor

Pull Request

🀨 Rationale

Adds Angular support for column placeholders, which is part of #1538.

πŸ‘©β€πŸ’» Implementation

Add placeholder to the 5 columns that support that property.

πŸ§ͺ Testing

Added unit tests

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

@atmgrifter00, will you buddy this PR for me?

@mollykreis mollykreis marked this pull request as ready for review March 27, 2024 20:42
@atmgrifter00 atmgrifter00 self-requested a review March 27, 2024 20:43
Copy link
Contributor

@atmgrifter00 atmgrifter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an example of the usage of this in the example project?

@rajsite
Copy link
Member

rajsite commented Mar 27, 2024

Should we add an example of the usage of this in the example project?

I don't feel strongly. Wouldn't necessarily do it for every column, maybe 1-2 if done. Whichever way just a reminder to keep it consistent across with blazor

@rajsite rajsite enabled auto-merge (squash) March 27, 2024 23:31
@rajsite rajsite merged commit a9ffce8 into main Mar 28, 2024
11 checks passed
@rajsite rajsite deleted the angular-column-placeholder branch March 28, 2024 00:28
@mollykreis mollykreis mentioned this pull request Mar 28, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants