Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lint and test concurrently #2048

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Run lint and test concurrently #2048

merged 4 commits into from
Apr 30, 2024

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Apr 30, 2024

Pull Request

🤨 Rationale

The lint and test commands are independent from each other and can run in parallel. Running them in parallel shaves off 4-5 min from the build following the pattern in SystemLinkShared with minimal additional complexity.

👩‍💻 Implementation

  • Use concurrently cli to run lint and test in parallel
  • Reduce the verbosity of test output by not logging passing tests

🧪 Testing

Rely on CI

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite merged commit cd00c0c into main Apr 30, 2024
13 checks passed
@rajsite rajsite deleted the concurrent-test-lint branch April 30, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants