Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lint and test concurrently #2048

Merged
merged 4 commits into from
Apr 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,8 @@ jobs:
exitOnceUploaded: true # Do not wait for test results
exitZeroOnChanges: true # Option to prevent the workflow from failing

# Lint
- run: npm run lint

# Test
- run: npm run test
# Lint and Test
- run: npm run concurrently-lint-test

# Run Lighthouse audit (from any push)
- name: Performance Audit with Lighthouse CI
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Try some less verbose test flags",
"packageName": "@ni/nimble-components",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Try some less verbose test flags",
"packageName": "@ni/spright-components",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "none"
}
135 changes: 135 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"invoke-publish": "cross-env-shell beachball publish --yes --access public --message \\\"applying package updates [skip ci]\\\" -n $NPM_SECRET_TOKEN",
"validate": "npm run build && npm run lint && npm run test",
"performance": "npm run performance --workspaces --if-present",
"beachball-sync": "beachball sync"
"beachball-sync": "beachball sync",
"concurrently-lint-test": "concurrently --group \"npm run lint\" \"npm run test\""
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -50,6 +51,7 @@
],
"devDependencies": {
"beachball": "^2.31.0",
"concurrently": "^8.2.2",
"cross-env": "^7.0.3",
"patch-package": "^8.0.0",
"playwright": "1.42.0"
Expand Down
7 changes: 6 additions & 1 deletion packages/nimble-components/karma.conf.verbose.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ module.exports = config => {
originalConfigFunction(config);
const options = {
plugins: [...config.plugins, 'karma-spec-reporter'],
reporters: [...config.reporters, 'spec']
reporters: [...config.reporters, 'spec'],
specReporter: {
suppressPassed: true,
suppressSkipped: false,
showSpecTiming: true
}
};

config.set(options);
Expand Down
7 changes: 6 additions & 1 deletion packages/spright-components/karma.conf.verbose.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ module.exports = config => {
originalConfigFunction(config);
const options = {
plugins: [...config.plugins, 'karma-spec-reporter'],
reporters: [...config.reporters, 'spec']
reporters: [...config.reporters, 'spec'],
specReporter: {
suppressPassed: true,
suppressSkipped: false,
showSpecTiming: true
}
};

config.set(options);
Expand Down
Loading