fix: P0 bugfixes and PR message generation#38
Merged
Conversation
- Transition plan status to merging while merge train is active - Add merging→running and merging→paused to valid plan transitions - Improve orchestrator createPR with job status table and real test config - Improve mc_pr tool with PR template lookup and conventional commit titles - Always include Mission Control attribution in PR bodies
nigel-dev
changed the title
…l format Plan name is used directly as the PR title. Tool descriptions and README updated to guide agents toward Conventional Commits format. Also fixes integration branch format in README docs (mc/integration/ → mc/integration-).
nigel-dev
deleted the
mc/integration-c1d14daf-d6be-4ab8-894c-9a890d7f1346
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 3 P0 critical bugs in the plan orchestration system, adds the missing plan
mergingstate transition, and improves PR message generation for both plan and standalone job PRs.Changes
P0 Bug Fixes
mc/integration/→mc/integration-)pre_mergecheckpoint loop viaapprovedForMergetrackingPlan State Machine
mergingwhile merge train is active, back torunningwhen queue drainsmerging→runningandmerging→pausedto valid plan transitionsPR Message Generation
createPR: Job status table, real test command from config (not hardcoded), Mission Control attributionmc_prtool: Conventional commit title format, PR template lookup (checks standard GitHub template locations), Mission Control attribution on all PRsTesting
bun run buildpassesbun test— 504/504 pass (includes new test for supervisor checkpoint fix)Notes
mc_prtool now checks for PR templates at standard GitHub locations in the job worktreeCloses #3, closes #10, closes #11
🚀 Automated PR from Mission Control