Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/mf32mt151 njsx #206

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fix/mf32mt151 njsx #206

merged 3 commits into from
Jul 10, 2024

Conversation

whaeck
Copy link
Member

@whaeck whaeck commented Jun 28, 2024

The NJSX value (the number of spin groups) is now read from the CONT record before the particle pairs in MF32 R-matrix limited uncertainties since SAMMY does not print the NJSX value on the particle pairs. The ENDF format bascially has the NJSX value appear in two places (on a CONT record before the particle pairs and on the particle pairs themselves) and ENDFtk used the second one while SAMMY only prints out the first one.

This "breaks" some interface functions (the R-matrix limited uncertainties from_string() function now requires the number of spin groups while previously it did not).

@whaeck whaeck requested a review from nathangibson14 June 28, 2024 20:12
Base automatically changed from fix/mf1mt451-sta to develop July 2, 2024 22:04
@whaeck whaeck requested a review from cjosey July 3, 2024 16:44
cjosey
cjosey previously approved these changes Jul 5, 2024
Copy link

@cjosey cjosey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know very much about the covariance stuff and SAMMY specifically, but the code changes look fine.

@whaeck whaeck merged commit fb113ba into develop Jul 10, 2024
8 checks passed
@whaeck whaeck deleted the fix/mf32mt151-njsx branch July 10, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants