-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler warnings related to nullability in Devices module #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnotheis
requested changes
Jan 17, 2024
...ation/PushNotifications/Commands/UpdateDeviceRegistration/UpdateDeviceRegistrationCommand.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.ConsumerApi/Controllers/IdentitiesController.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Domain/Aggregates/PushNotifications/PnsRegistration.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Domain/Aggregates/PushNotifications/PnsRegistration.cs
Show resolved
Hide resolved
Modules/Devices/src/Devices.Infrastructure/Persistence/Database/DevicesDbContext.cs
Outdated
Show resolved
Hide resolved
...s.Infrastructure/Persistence/Database/ValueConverters/TierIdEntityFrameworkValueConverter.cs
Outdated
Show resolved
Hide resolved
...s.Infrastructure/Persistence/Database/ValueConverters/TierIdEntityFrameworkValueConverter.cs
Outdated
Show resolved
Hide resolved
...ces/src/Devices.Infrastructure/PushNotifications/DirectPush/DirectPnsCommunicationOptions.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/test/Devices.Infrastructure.Tests/Tests/DirectPush/DirectPushServiceTests.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/test/Devices.Infrastructure.Tests/Tests/DirectPush/DirectPushServiceTests.cs
Outdated
Show resolved
Hide resolved
tnotheis
requested changes
Jan 19, 2024
...ation/PushNotifications/Commands/UpdateDeviceRegistration/UpdateDeviceRegistrationCommand.cs
Outdated
Show resolved
Hide resolved
Modules/Devices/src/Devices.Domain/Aggregates/PushNotifications/PnsRegistration.cs
Show resolved
Hide resolved
...ces/src/Devices.Infrastructure/PushNotifications/DirectPush/DirectPnsCommunicationOptions.cs
Outdated
Show resolved
Hide resolved
...s/Devices/test/Devices.Application.Tests/Tests/Devices/Commands/DeleteDevice/HandlerTests.cs
Outdated
Show resolved
Hide resolved
...s/Devices/test/Devices.Application.Tests/Tests/Devices/Commands/DeleteDevice/HandlerTests.cs
Show resolved
Hide resolved
refactor: remove nullable mark from the input param as it is never null
…he single call of the method suppresses null warnings
…nto fix-devices-code-issues
…nto fix-devices-code-issues
…ty but the properties are then immediately set
tnotheis
approved these changes
Feb 19, 2024
tnotheis
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I need to check one more thing
tnotheis
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readiness checklist
Description
Various code issues and warnings related to
null
values found using the ReSharper tool in theDevices
module were investigated and addressed.Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores