Fix compiler warnings related to nullability in Devices module

BuildingBlocks/src/BuildingBlocks.Application.Abstractions/Infrastructure/Persistence/Database/IDbContext.cs

@@ -15,7 +15,7 @@ Task RunInTransaction(Func<Task> action, List<int> errorNumbersToRetry,
 
     Task RunInTransaction(Func<Task> action, IsolationLevel isolationLevel);
 
-    Task<T?> RunInTransaction<T>(Func<Task<T?>> action, List<int> errorNumbersToRetry,
+    Task<T?> RunInTransaction<T>(Func<Task<T?>> action, List<int>? errorNumbersToRetry,
         IsolationLevel isolationLevel = IsolationLevel.ReadCommitted);
 
     Task<T?> RunInTransaction<T>(Func<Task<T?>> func, IsolationLevel isolationLevel);

Modules/Devices/src/Devices.Application/Devices.Application.csproj

@@ -1,6 +1,10 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
-	<ItemGroup>
+    <PropertyGroup>
+        <Nullable>enable</Nullable>
+    </PropertyGroup>
+
+    <ItemGroup>
 		<PackageReference Include="AutoMapper.Extensions.Microsoft.DependencyInjection" Version="12.0.1" />
 		<PackageReference Include="FluentValidation" Version="11.8.1" />
 		<PackageReference Include="FluentValidation.DependencyInjectionExtensions" Version="11.8.1" />

Modules/Devices/src/Devices.Application/PushNotifications/Commands/UpdateDeviceRegistration/UpdateDeviceRegistrationCommand.cs

@@ -7,5 +7,5 @@ public class UpdateDeviceRegistrationCommand : IRequest<UpdateDeviceRegistration
     public string Platform { get; set; }
     public string Handle { get; set; }
     public string AppId { get; set; }
-    public string Environment { get; set; }
+    public string? Environment { get; set; }
 }

Modules/Devices/src/Devices.ConsumerApi/Controllers/IdentitiesController.cs

@@ -63,7 +63,7 @@ public class CreateIdentityRequest
     public required string ClientSecret { get; set; }
     public required byte[] IdentityPublicKey { get; set; }
     public required string DevicePassword { get; set; }
-    public byte IdentityVersion { get; set; }
+    public required byte IdentityVersion { get; set; }
     public required CreateIdentityRequestSignedChallenge SignedChallenge { get; set; }
 }
 

Modules/Devices/src/Devices.Domain/Aggregates/PushNotifications/PnsRegistration.cs

@@ -8,7 +8,16 @@ namespace Backbone.Modules.Devices.Domain.Aggregates.PushNotifications;
 public class PnsRegistration
 {
     // ReSharper disable once UnusedMember.Local
-    private PnsRegistration() { }
+    private PnsRegistration()
+    {
+        IdentityAddress = null!;
+        DeviceId = null!;
+        DevicePushIdentifier = null!;
+        Handle = null!;
+        UpdatedAt = SystemTime.UtcNow;
+        AppId = null!;
+        Environment = PushEnvironment.Development;
+    }
 
     public PnsRegistration(IdentityAddress identityAddress, DeviceId deviceId, PnsHandle handle, string appId, PushEnvironment environment)
     {
@@ -21,11 +30,11 @@ public PnsRegistration(IdentityAddress identityAddress, DeviceId deviceId, PnsHa
         Environment = environment;
     }
 
-    public IdentityAddress IdentityAddress { get; } = null!;
-    public DeviceId DeviceId { get; } = null!;
-    public DevicePushIdentifier DevicePushIdentifier { get; private set; } = null!;
-    public PnsHandle Handle { get; private set; } = null!;
-    public string AppId { get; private set; } = null!;
+    public IdentityAddress IdentityAddress { get; }
+    public DeviceId DeviceId { get; }
+    public DevicePushIdentifier DevicePushIdentifier { get; private set; }
+    public PnsHandle Handle { get; private set; }
+    public string AppId { get; private set; }
     public DateTime UpdatedAt { get; private set; }
     public PushEnvironment Environment { get; private set; }
 

Modules/Devices/src/Devices.Infrastructure/Devices.Infrastructure.csproj

@@ -1,6 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
+        <Nullable>enable</Nullable>
     </PropertyGroup>
 
     <ItemGroup>

Modules/Devices/src/Devices.Infrastructure/Persistence/Database/DevicesDbContext.cs

@@ -16,20 +16,21 @@
 using Microsoft.Extensions.DependencyInjection;
 using Npgsql.EntityFrameworkCore.PostgreSQL;
 
+#pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.
+
 namespace Backbone.Modules.Devices.Infrastructure.Persistence.Database;
 
 public class DevicesDbContext : IdentityDbContext<ApplicationUser>, IDevicesDbContext
 {
-    private readonly IServiceProvider _serviceProvider;
+    private readonly IServiceProvider? _serviceProvider;
     private const int MAX_RETRY_COUNT = 50000;
     private static readonly TimeSpan MAX_RETRY_DELAY = TimeSpan.FromSeconds(1);
     private const string SQLSERVER = "Microsoft.EntityFrameworkCore.SqlServer";
     private const string POSTGRES = "Npgsql.EntityFrameworkCore.PostgreSQL";
 
     public DevicesDbContext(DbContextOptions<DevicesDbContext> options)
         : base(options)
-    {
-    }
+    { }
 
     public DevicesDbContext(DbContextOptions<DevicesDbContext> options, IServiceProvider serviceProvider)
         : base(options)
@@ -60,7 +61,7 @@ protected override void OnConfiguring(DbContextOptionsBuilder optionsBuilder)
             optionsBuilder.AddInterceptors(_serviceProvider.GetRequiredService<SaveChangesTimeInterceptor>());
     }
 
-    public async Task RunInTransaction(Func<Task> action, List<int> errorNumbersToRetry,
+    public async Task RunInTransaction(Func<Task> action, List<int>? errorNumbersToRetry,
         IsolationLevel isolationLevel = IsolationLevel.ReadCommitted)
     {
         ExecutionStrategy executionStrategy;
@@ -70,7 +71,6 @@ public async Task RunInTransaction(Func<Task> action, List<int> errorNumbersToRe
                 executionStrategy = new SqlServerRetryingExecutionStrategy(this, MAX_RETRY_COUNT, MAX_RETRY_DELAY, errorNumbersToRetry);
                 break;
             case POSTGRES:
-                // ReSharper disable once ConditionIsAlwaysTrueOrFalse
                 var errorCodesToRetry = errorNumbersToRetry != null ? errorNumbersToRetry.ConvertAll(x => x.ToString()) : new List<string>();
                 executionStrategy = new NpgsqlRetryingExecutionStrategy(this, MAX_RETRY_COUNT, MAX_RETRY_DELAY, errorCodesToRetry);
                 break;
@@ -88,10 +88,10 @@ await executionStrategy.ExecuteAsync(async () =>
 
     public async Task RunInTransaction(Func<Task> action, IsolationLevel isolationLevel)
     {
-        await RunInTransaction(action, null!, isolationLevel);
+        await RunInTransaction(action, null, isolationLevel);
     }
 
-    public async Task<T> RunInTransaction<T>(Func<Task<T>> action, List<int> errorNumbersToRetry,
+    public async Task<T?> RunInTransaction<T>(Func<Task<T?>> action, List<int>? errorNumbersToRetry,
         IsolationLevel isolationLevel = IsolationLevel.ReadCommitted)
     {
         var response = default(T);
@@ -101,9 +101,9 @@ public async Task<T> RunInTransaction<T>(Func<Task<T>> action, List<int> errorNu
         return response;
     }
 
-    public async Task<T> RunInTransaction<T>(Func<Task<T>> func, IsolationLevel isolationLevel)
+    public async Task<T?> RunInTransaction<T>(Func<Task<T?>> func, IsolationLevel isolationLevel)
     {
-        return await RunInTransaction(func, null!, isolationLevel);
+        return await RunInTransaction(func, null, isolationLevel);
     }
 
     public List<string> GetFcmAppIdsForWhichNoConfigurationExists(ICollection<string> supportedAppIds)

Modules/Devices/src/Devices.Infrastructure/Persistence/Database/ValueConverters/DevicePushIdentifierEntityFrameworkValueConverter.cs

@@ -6,7 +6,7 @@ internal class DevicePushIdentifierEntityFrameworkValueConverter : ValueConverte
 {
     public DevicePushIdentifierEntityFrameworkValueConverter() : this(null) { }
 
-    public DevicePushIdentifierEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
+    public DevicePushIdentifierEntityFrameworkValueConverter(ConverterMappingHints? mappingHints)
         : base(
             dpi => dpi.StringValue,
             value => DevicePushIdentifier.Parse(value),

Modules/Devices/src/Devices.Infrastructure/Persistence/Database/ValueConverters/PnsHandleEntityFrameworkValueConverter.cs

@@ -9,7 +9,7 @@ public PnsHandleEntityFrameworkValueConverter() : this(null)
     {
     }
 
-    public PnsHandleEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
+    public PnsHandleEntityFrameworkValueConverter(ConverterMappingHints? mappingHints)
         : base(
             pnsHandle => SerializeHandle(pnsHandle),
             value => DeserializeHandle(value),

Modules/Devices/src/Devices.Infrastructure/Persistence/Database/ValueConverters/TierIdEntityFrameworkValueConverter.cs

@@ -9,7 +9,7 @@ public TierIdEntityFrameworkValueConverter() : this(null)
     {
     }
 
-    public TierIdEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
+    public TierIdEntityFrameworkValueConverter(ConverterMappingHints? mappingHints)
         : base(
             id => id.Value,
             value => TierId.Create(value).Value,
@@ -19,13 +19,13 @@ public TierIdEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
     }
 }
 
-public class NullableTierIdValueConverter : ValueConverter<TierId, string>
+public class NullableTierIdValueConverter : ValueConverter<TierId?, string?>
 {
     public NullableTierIdValueConverter() : this(null)
     {
     }
 
-    public NullableTierIdValueConverter(ConverterMappingHints mappingHints)
+    public NullableTierIdValueConverter(ConverterMappingHints? mappingHints)
         : base(
             id => id == null ? null : id.Value,
             value => value == null ? null : TierId.Create(value).Value,

Modules/Devices/src/Devices.Infrastructure/Persistence/Database/ValueConverters/TierNameEntityFrameworkValueConverter.cs

@@ -8,7 +8,7 @@ public TierNameEntityFrameworkValueConverter() : this(null)
     {
     }
 
-    public TierNameEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
+    public TierNameEntityFrameworkValueConverter(ConverterMappingHints? mappingHints)
         : base(
             id => id.Value,
             value => TierName.Create(value).Value,
@@ -18,13 +18,13 @@ public TierNameEntityFrameworkValueConverter(ConverterMappingHints mappingHints)
     }
 }
 
-public class NullableTierNameValueConverter : ValueConverter<TierName, string>
+public class NullableTierNameValueConverter : ValueConverter<TierName?, string?>
 {
     public NullableTierNameValueConverter() : this(null)
     {
     }
 
-    public NullableTierNameValueConverter(ConverterMappingHints mappingHints)
+    public NullableTierNameValueConverter(ConverterMappingHints? mappingHints)
         : base(
             id => id == null ? null : id.Value,
             value => value == null ? null : TierName.Create(value).Value,

Modules/Devices/src/Devices.Infrastructure/PushNotifications/DirectPush/DirectPnsCommunicationOptions.cs

@@ -37,7 +37,7 @@ public bool HasConfigForAppId(string appId)
             return serviceAccountForServiceAccountNameExists;
         }
 
-        public string GetServiceAccountForAppId(string appId)
+        public string GetServiceAccountForAppId(string? appId)
         {
             var app = Apps.GetValueOrDefault(appId);
 

Modules/Devices/test/Devices.Application.Tests/Devices.Application.Tests.csproj

@@ -2,6 +2,7 @@
 
 	<PropertyGroup>
 		<IsPackable>false</IsPackable>
+        <Nullable>enable</Nullable>
 	</PropertyGroup>
 
 	<ItemGroup>

Modules/Devices/test/Devices.Infrastructure.Tests/Tests/DirectPush/DirectPushServiceTests.cs

@@ -22,8 +22,8 @@ public async void Update_of_a_registration_that_does_not_exist_yet()
 
         var mockPnsRegistrationsRepository = A.Fake<IPnsRegistrationsRepository>();
 
-        A.CallTo(() => mockPnsRegistrationsRepository.FindByDeviceId(deviceId, A<CancellationToken>._, A<bool>._))
-           .Returns((PnsRegistration)null!).Once();
+        A.CallTo(() => mockPnsRegistrationsRepository.FindByDeviceId(deviceId, A<CancellationToken>._, A<bool>._))!
+           .Returns((PnsRegistration?)null).Once();
 
         var directPushService = CreateDirectPushService(mockPnsRegistrationsRepository);
 
@@ -97,8 +97,8 @@ public async void Trying_to_delete_non_existing_PnsRegistration_does_nothing()
 
         var mockPnsRegistrationsRepository = A.Fake<IPnsRegistrationsRepository>();
 
-        A.CallTo(() => mockPnsRegistrationsRepository.FindByDeviceId(deviceId, A<CancellationToken>._, A<bool>._))
-           .Returns((PnsRegistration)null!);
+        A.CallTo(() => mockPnsRegistrationsRepository.FindByDeviceId(deviceId, A<CancellationToken>._, A<bool>._))!
+           .Returns((PnsRegistration?)null);
 
         var directPushService = CreateDirectPushService(mockPnsRegistrationsRepository);