Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[coverity] fix coverity issues #2518

Merged
merged 1 commit into from
Mar 28, 2024
Merged

[coverity] fix coverity issues #2518

merged 1 commit into from
Mar 28, 2024

Conversation

lhs8928
Copy link
Contributor

@lhs8928 lhs8928 commented Mar 25, 2024

  • Added const auto & to avoid copy of an object
  • Added missing lock

@taos-ci
Copy link

taos-ci commented Mar 25, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2518. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link

taos-ci commented Mar 25, 2024

:octocat: cibot: @lhs8928, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2518-202403251944510.47950410842896-e17ed14d27a0fedb48c81ea56d4d1f5022afbb10/.

skykongkong8
skykongkong8 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DonghakPark
DonghakPark approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhs8928 lhs8928 force-pushed the fix_ahub_240325 branch 2 times, most recently from 60f64a5 to f924faa Compare March 26, 2024 06:46
djeong20
djeong20 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

taos-ci
taos-ci approved these changes Mar 26, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhs8928, 💯 All CI checkers are successfully verified. Thanks.

@lhs8928 lhs8928 force-pushed the fix_ahub_240325 branch 2 times, most recently from 6e1190d to 39c0a8c Compare March 27, 2024 07:08
taos-ci
taos-ci approved these changes Mar 27, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhs8928, 💯 All CI checkers are successfully verified. Thanks.

@lhs8928
[coverity] fix coverity issues
baf396c 
 - Added const auto & to avoid copy of an object
 - Added missing lock

Signed-off-by: hyeonseok lee <hs89.lee@samsung.com>
taos-ci
taos-ci approved these changes Mar 27, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhs8928, 💯 All CI checkers are successfully verified. Thanks.

@jijoongmoon jijoongmoon merged commit 5fbaf16 into nnstreamer:main Mar 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taos-ci taos-ci taos-ci approved these changes

@DonghakPark DonghakPark DonghakPark approved these changes

@djeong20 djeong20 djeong20 approved these changes

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@SeoHyungjun SeoHyungjun Awaiting requested review from SeoHyungjun SeoHyungjun is a code owner

@baek2sm baek2sm Awaiting requested review from baek2sm baek2sm is a code owner

@EunjuYang EunjuYang Awaiting requested review from EunjuYang EunjuYang is a code owner

Assignees
No one assigned
Labels
PR/READY2MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lhs8928 @taos-ci @DonghakPark @djeong20 @skykongkong8 @jijoongmoon