Remove explicit installation of setuptools #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
reviewed
Dec 28, 2024
| @@ -696,7 +696,7 @@ def main(args): | |||
| return 1 | |||
|
|
|||
|
|
|||
| # NOTE: setuptools generated console_scripts calls function with no arguments | |||
| # NOTE: console_scripts calls this function with no arguments | |||
There was a problem hiding this comment.
I think the original comment is still correct and concise as this function is referenced in pyproject.toml#project.scripts?
There was a problem hiding this comment.
The Python Packaging Authortiy has respecified console_scripts to be supported beyond setuptools as discussed at
https://packaging.python.org/en/latest/specifications/entry-points
Jayman2000
approved these changes
Dec 29, 2024
There was a problem hiding this comment.
I created a script that tests this PR in Python 3.8 through Python 3.13. Everything seems to work fine in all of those versions of Python.
legendecas
approved these changes
Dec 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #277
setuptools#277@Jayman2000