Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit installation of setuptools #278

Merged
merged 1 commit into from
Dec 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/node-gyp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- name: Install Python dependencies
run: |
cd gyp-next
python -m pip install --upgrade pip setuptools
python -m pip install --upgrade pip
pip install --editable .
pip uninstall -y gyp-next
- name: Install Node.js dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/python_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: seanmiddleditch/gha-setup-ninja@v5
- name: Install dependencies
run: |
python -m pip install --upgrade pip setuptools
python -m pip install --upgrade pip
pip install --editable ".[dev]"
- run: ./gyp -V && ./gyp --version && gyp -V && gyp --version
- name: Lint with ruff # See pyproject.toml for settings
Expand Down
2 changes: 1 addition & 1 deletion docs/Hacking.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ to make sure your changes aren't breaking anything important.
You run the test driver with e.g.

``` sh
$ python -m pip install --upgrade pip setuptools
$ python -m pip install --upgrade pip
$ pip install --editable ".[dev]"
$ python -m pytest
```
Expand Down
2 changes: 1 addition & 1 deletion pylib/gyp/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ def main(args):
return 1


# NOTE: setuptools generated console_scripts calls function with no arguments
# NOTE: console_scripts calls this function with no arguments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original comment is still correct and concise as this function is referenced in pyproject.toml#project.scripts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python Packaging Authortiy has respecified console_scripts to be supported beyond setuptools as discussed at
https://packaging.python.org/en/latest/specifications/entry-points

def script_main():
return main(sys.argv[1:])

Expand Down
Loading