Skip to content

fix tests#78

Merged
nolanderc merged 2 commits intonolanderc:mainfrom
xav-ie:fix-tests
Oct 16, 2025
Merged

fix tests#78
nolanderc merged 2 commits intonolanderc:mainfrom
xav-ie:fix-tests

Conversation

@xav-ie
Copy link
Contributor

@xav-ie xav-ie commented Jun 30, 2025

This PR:

  • test(update): test hover was outdated
  • test(tokenPaste.vert): disable - not yet supported

Next PR A: #79

  • feat(--format): add subcommand
  • test(--format): add cli tests

Next PR B: #80

  • feat(tab_size): add support
  • test(tab_size): verify configurable tab size

These tests were failing for me. Maybe I did something wrong?

@xav-ie xav-ie marked this pull request as ready for review June 30, 2025 11:28
This was referenced Jun 30, 2025
@xav-ie
Copy link
Contributor Author

xav-ie commented Sep 26, 2025

Hey @nolanderc , I just want to @ you in case you forgot or have not seen this yet. I tried to split up my work to make it easier to review. I also used conventional commits to communicate why I made these changes. I believe my code changes are generally desired.

This file contains many macros and edge cases that are not yet broken
down or started work on. It causes tests to fail.
@nolanderc
Copy link
Owner

Thanks a lot! These tests were always a bit wonky, so it's much appreciated that someone has taken the time to address at least a few of the issues 😸

@nolanderc nolanderc merged commit d35c78f into nolanderc:main Oct 16, 2025
9 checks passed
@nolanderc nolanderc mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants