Merged
Conversation
Contributor
Author
|
Hey @nolanderc , I just want to @ you in case you forgot or have not seen this yet. I tried to split up my work to make it easier to review. I also used conventional commits to communicate why I made these changes. I believe my code changes are generally desired. |
This file contains many macros and edge cases that are not yet broken down or started work on. It causes tests to fail.
Owner
|
Thanks a lot! These tests were always a bit wonky, so it's much appreciated that someone has taken the time to address at least a few of the issues 😸 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Next PR A: #79
Next PR B: #80
These tests were failing for me. Maybe I did something wrong?