Merged
Conversation
Merged
Merged
Verifies expected outputs and failures.
a005988 to
c8379d8
Compare
Owner
|
Thanks! Seems like a nice feature to have 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous PR (merge this first pls!): #78
This PR:
Hello, I currently have repo-wide formatting setup and have been using clangd format for glsl files. Now that glsl_analyzer has formatting, my clangd cli formatter and glsl_analyzer LSP auto-formatter have different opinions on tabs. Gah! This is causing a lot of issues for me.
I would like to set this up to use from cli just like clangd allows. This means that I need a way to meet this formatter specification:
https://treefmt.com/latest/reference/formatter-spec/
Please accept my PR so I may format with this formatter!
I am happy to accept feedback and make changes.
I actually need to extend this functionality to eventually write to the file as well. I think that should be something like
--format --write. Let me know your thoughts. I am used toprettiercommand that operates like this.