Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/inputgain and selector not in set channel #348

Closed

Conversation

olzzon
Copy link
Contributor

@olzzon olzzon commented Sep 20, 2024

About the Contributor

This PR is contributed on behalf of BBC

Type of Contribution

This is a: Bug fix

Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)

Current Behavior

When using Sisyfos.setChannel() inputGain and inputSelector was not send to Sisyfos.

New Behavior

inputGain and inputSelector are now send to Sisyfos when using setChannel

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

olzzon and others added 22 commits March 15, 2024 09:09
…a mapped layer

Co-authored-by: Johan Nyman <johan@nytamin.se>
…Refactor SET_CHANNEL

Co-authored-by: Johan Nyman <johan@nytamin.se>
Co-authored-by: Johan Nyman <johan@nytamin.se>
@olzzon olzzon requested a review from a team as a code owner September 20, 2024 11:46
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 26.76056% with 52 lines in your changes missing coverage. Please review.

Project coverage is 56.50%. Comparing base (6cecf90) to head (a14d8d1).
Report is 37 commits behind head on release52.

Files with missing lines Patch % Lines
...te-resolver/src/integrations/sisyfos/connection.ts 34.00% 28 Missing and 5 partials ⚠️
...e-state-resolver/src/integrations/sisyfos/index.ts 0.00% 16 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           release52     #348      +/-   ##
=============================================
+ Coverage      55.71%   56.50%   +0.78%     
=============================================
  Files            129      131       +2     
  Lines          10117    10283     +166     
  Branches        2520     2563      +43     
=============================================
+ Hits            5637     5810     +173     
+ Misses          4103     4096       -7     
  Partials         377      377              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants