-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/inputgain and selector not in set channel #348
Closed
olzzon
wants to merge
22
commits into
nrkno:release52
from
bbc:fix/inputgain-and-selector-not-in-set-channel
Closed
Fix/inputgain and selector not in set channel #348
olzzon
wants to merge
22
commits into
nrkno:release52
from
bbc:fix/inputgain-and-selector-not-in-set-channel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a mapped layer Co-authored-by: Johan Nyman <johan@nytamin.se>
…Refactor SET_CHANNEL Co-authored-by: Johan Nyman <johan@nytamin.se>
Co-authored-by: Johan Nyman <johan@nytamin.se>
…as the functionality)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release52 #348 +/- ##
=============================================
+ Coverage 55.71% 56.50% +0.78%
=============================================
Files 129 131 +2
Lines 10117 10283 +166
Branches 2520 2563 +43
=============================================
+ Hits 5637 5810 +173
+ Misses 4103 4096 -7
Partials 377 377 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR is contributed on behalf of BBC
Type of Contribution
This is a: Bug fix
Bug fix / Feature / Code improvement / Documentation improvement / Other (please specify)
Current Behavior
When using Sisyfos.setChannel() inputGain and inputSelector was not send to Sisyfos.
New Behavior
inputGain and inputSelector are now send to Sisyfos when using setChannel
Testing Instructions
Other Information
Status