Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/inputgain and selector not in set channel #348

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4696190
wip: get state from single channel
olzzon Mar 15, 2024
d0adc7c
wip: get state from single channel - rename to resyncChannel from rei…
olzzon Mar 15, 2024
6823634
fix: function name started with uppercase
olzzon Mar 15, 2024
685fbf9
feat: SetSisyfosChannelState action implemented
olzzon Mar 15, 2024
2f7d553
feat: Sisyfos support for set input gain and set input selector
olzzon Mar 15, 2024
116bd76
fix: actions.json payload format
olzzon Mar 15, 2024
5a23c41
chore: add script test:changed
olzzon Mar 18, 2024
dcfa14f
fix: fadeTime should be optional
olzzon Mar 18, 2024
5f5115e
fix: add mute, inputgain, inputselector to Sisyfos channel option types
olzzon Mar 18, 2024
547247f
fix: quickTSR - return error info if an object does not reference to …
olzzon Mar 19, 2024
67d566e
fix: Sisyfos add mute, gain and inputselctor to diif
olzzon Mar 19, 2024
5bd34b3
fix: Sisyfos update mute, inputgain, selector in state from new state
olzzon Mar 19, 2024
25c6516
feat: Sisyfos add support for mute, gain, selector in triggerValues. …
olzzon Mar 20, 2024
e36853f
fix: Sisyfos setchannel wrong index and osc format
olzzon Apr 2, 2024
b06a79b
fix: sisyfos receive channel number as index
olzzon Apr 2, 2024
f04970c
fix: setState when received update from Sisyfos
olzzon Apr 2, 2024
9af2d5c
fix: Sisyfos Typings and conversion for pgmOn and visibilty between T…
olzzon Apr 2, 2024
cc22ae5
wip: Sisyfos - EventEmitter types, restructure timeOut to event emit
olzzon Apr 4, 2024
4e77eb2
feat: Sisyfos - remove re-sync channel functionality. (triggerValue h…
olzzon Apr 10, 2024
3cb6f70
fix: Sisyfos add triggerValue to TimelineContentSisyfosChannel
olzzon Apr 10, 2024
115148e
Merge branch 'feat/sisyfos-bbc-enhancements' into bbc-release51-beta
olzzon Aug 19, 2024
a14d8d1
fix: using Sisyfos set channel didn't send inputgain and input selector
olzzon Sep 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"build:main": "cd packages/timeline-state-resolver && yarn build",
"lint": "lerna exec yarn lint -- --",
"test": "lerna exec yarn test",
"test:changed": "lerna run --since origin/master --include-dependents test",
"unit": "lerna exec yarn unit",
"unitci": "lerna exec yarn unitci",
"watch": "lerna run --parallel build:main -- --watch --preserveWatchOutput",
Expand Down
6 changes: 6 additions & 0 deletions packages/quick-tsr/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,12 @@ function reloadInput(changed?: { path: string; stats: fs.Stats }) {
currentInput.mappings = clone(newInput.mappings)
currentInput.timeline = clone(newInput.timeline)

// Check that layers are correct.
newInput.timeline.forEach((obj) => {
if (!newInput.mappings[obj.layer])
console.error(`Object ${obj.id} refers to a layer/mapping that does not exist: "${obj.layer}"`)
})

tsr.setTimelineAndMappings(newInput.timeline, newInput.mappings)
}
if (!_.isEqual(newInput.datastore, currentInput.datastore)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,17 @@ export enum MappingSisyfosType {

export type SomeMappingSisyfos = MappingSisyfosChannel | MappingSisyfosChannelByLabel | MappingSisyfosChannels

export interface SetSisyfosChannelStatePayload {
channel: number
}

export enum SisyfosActions {
Reinit = 'reinit'
Reinit = 'reinit',
SetSisyfosChannelState = 'setSisyfosChannelState'
}
export interface SisyfosActionExecutionResults {
reinit: () => void
reinit: () => void,
setSisyfosChannelState: (payload: SetSisyfosChannelStatePayload) => void
}
export type SisyfosActionExecutionPayload<A extends keyof SisyfosActionExecutionResults> = Parameters<
SisyfosActionExecutionResults[A]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import { DeviceType } from '..'

/*
* TRIGGERVALUE is used to SET_CHANNEL in Sisyfos
* When value is changed to a new value (e.g. Date.now()) Sisyfos will set the channel to
* the Current TSR State using setSisyfosChannel()
*/
export enum TimelineContentTypeSisyfos {
CHANNEL = 'channel',
CHANNELS = 'channels',
Expand All @@ -22,6 +27,9 @@ export interface SisyfosChannelOptions {
label?: string
visible?: boolean
fadeTime?: number
muteOn?: boolean
inputGain?: number
inputSelector?: number
}

export interface TimelineContentSisyfosTriggerValue extends TimelineContentSisyfos {
Expand All @@ -33,6 +41,7 @@ export interface TimelineContentSisyfosChannel extends TimelineContentSisyfos, S
type: TimelineContentTypeSisyfos.CHANNEL
resync?: boolean
overridePriority?: number // defaults to 0
triggerValue?: string
}
export interface TimelineContentSisyfosChannels extends TimelineContentSisyfos {
type: TimelineContentTypeSisyfos.CHANNELS
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,22 @@
"name": "Reinitialize",
"destructive": false,
"timeout": 5000
},
{
"id": "setSisyfosChannelState",
"name": "SetSisyfosChannelState",
"payload": {
"type": "object",
"properties": {
"channel": {
"type": "number"
}
},
"additionalProperties": false,
"required": ["channel"]
},
"destructive": false,
"timeout": 5000
}
]
}
}
Loading
Loading