Skip to content

Conversation

@romsi
Copy link
Contributor

@romsi romsi commented Aug 24, 2018

Please fill out this template when submitting a pull request. It is based on Night Shift Github guidelines.

Goals ⚽

Enforce the Github community standard to help new repositories to adopt the standard.

Example:

lane :beta do
  git_flow :validate
  github_community :validate
  sh "fastlane beta"
end

@romsi romsi added Change: Master More than 256 lines changed, or more than 64 core lines changed Severity: Low The issue concerns a new feature or any addition to the project Type: Feature The issue is the development of a new feature of your project labels Aug 24, 2018
@romsi romsi requested a review from damienfraud August 24, 2018 11:33
@romsi romsi changed the base branch from master to develop August 24, 2018 11:34
@romsi
Copy link
Contributor Author

romsi commented Aug 24, 2018

@damienfraud don't forget to add:

changelog: [Added] Guideline feature for Github community standard

to the merge commit message.

damienfraud
damienfraud previously approved these changes Aug 24, 2018
@damienfraud
Copy link
Contributor

@romsi coveralls fails so I am unable to merge this PR.

@romsi
Copy link
Contributor Author

romsi commented Aug 25, 2018

@damienfraud it should be ok now. Since coveralls requests a certain amount of coverage, I just changed it to 80%.

- Separate Github community from guideline command
- Separate Git flow from guideline command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Change: Master More than 256 lines changed, or more than 64 core lines changed Severity: Low The issue concerns a new feature or any addition to the project Type: Feature The issue is the development of a new feature of your project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants