Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queue cutoff line and queue join cooldown #14

Merged
merged 15 commits into from
Jun 17, 2022
Merged

Add queue cutoff line and queue join cooldown #14

merged 15 commits into from
Jun 17, 2022

Conversation

NicholasBottone
Copy link
Contributor

@NicholasBottone NicholasBottone commented Jun 5, 2022 •
edited
Loading

This PR contains the backend changes necessary for the frontend changes proposed in nthnluu/hours-frontend#40

NicholasBottone and others added 11 commits April 10, 2022 17:29
@NicholasBottone @josue-creator
CutoffQueue request sets CutoffTicketID for storing cutoff line
474d61c 
Co-authored-by: josue-creator <josue_cruz@brown.edu>
@NicholasBottone @josue-creator
Handle updating CutoffTicketID when tickets are deleted
47c6b34 
Co-authored-by: josue-creator <josue_cruz@brown.edu>
@NicholasBottone @josue-creator
Handle disabling the cutoff when queue is shuffled
927ae0d 
Co-authored-by: josue-creator <josue_cruz@brown.edu>
@NicholasBottone
Fix finding index of ticket to be deleted
1961470
@NicholasBottone
Fix removing cutoff ticket from queue array on ticket deletion
b251761
@nickyy96
FEAT: added some functionality to the cooldown
e9fd5da
@nickyy96
FEAT: 15 minute backend cooldown
dca144d
@NicholasBottone
Merge remote-tracking branch 'origin/nyarnall_branch' into 4-queue-cu…
5d2d606 
…toff-new
@NicholasBottone
Handle updating the cutoff line position when a ticket is marked as c…
3422d30 
…ompleted
@NicholasBottone
Handle moving cutoff line to the top of the queue
e4da1b5
@NicholasBottone
Fix cutoff looking at tickets array instead of visibletickets array
55e988f
This was referenced Jun 5, 2022
Open
Open
@NicholasBottone NicholasBottone mentioned this pull request Jun 5, 2022
Merged
@NicholasBottone NicholasBottone changed the title Add queue cutoff line Add queue cutoff line and queue join cooldown Jun 17, 2022
n-young
n-young requested changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@n-young n-young left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment, seems like there is opportunity to reduce code duplication. also confused on the policy and new queue struct

internal/models/queue.go Show resolved Hide resolved
internal/repository/queue.go Show resolved Hide resolved
@nthnluu nthnluu merged commit e6feb47 into nthnluu:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-young n-young n-young approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NicholasBottone @n-young @nthnluu @nickyy96 @alexander-ding