-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add queue cutoff line and queue join cooldown (resolves #29 and resolves #31) #40
base: main
Are you sure you want to change the base?
Add queue cutoff line and queue join cooldown (resolves #29 and resolves #31) #40
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @nthnluu on Vercel. @nthnluu first needs to authorize it. |
15 minute cooldown merge
Small refactorings
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, it'd be nice to see screenshots though. i'll approve now, could someone send me screenshots via slack before merging? tks
@n-young @nthnluu @neilramaswamy I think I've resolved any issues, please review again and see if there is anything else that needs changing before release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly style comments; I didn't actually run this but most of this looks like it'll work. I also expect that the time-limit will be enforced on the backend, correct?
Not sure why github isn't letting me request re-review, but addressed PR feedback again @nthnluu @neilramaswamy |
Resolves #29 and resolves #31
Requires backend changes proposed in nthnluu/hours-backend#14