-
Notifications
You must be signed in to change notification settings - Fork 24
Update to nucypher-core@0.12.0
#273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
manumonti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✌️
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@nucypher/nucypher-core": "^0.11.0", | ||
| "@nucypher/nucypher-core": "file:../nucypher-core/nucypher-core-wasm/pkg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose this line will be changed when nucypher/nucypher-core#77 is merged, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but specifically when we release @nucypher/nucypher-core@0.12.0 on npm.
|
Bundled size for the package is listed below: build/main/src/characters: 74.22 KB |
| public async retrieveAndDecrypt( | ||
| provider: ethers.providers.Web3Provider, | ||
| conditionExpr: ConditionExpression, | ||
| ciphertext: Ciphertext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this instead be ThresholdMessageKit and not Ciphertext...?
| ciphertext: Ciphertext, | ||
| acp: AccessControlPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piotr-roslaniec Should this just be ThreshodlMessageKit? It has the ciphertext and the acp in it...?
|
@derekpierre I will fix those in a follow-up PR. |
Type of PR:
Required reviews:
What this does:
nucypher-coreversionIssues fixed/closed:
Why it's needed:
Notes for reviewers:
@nucypher/nucypher-core@0.12.0to be released on npm to merge this PRnucypher-coreversion