-
Notifications
You must be signed in to change notification settings - Fork 8
test: Add initial e2e tests #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b45c6e6
to
bcc5d1b
Compare
046be5a
to
36af665
Compare
25839cf
to
3c4796b
Compare
3c4796b
to
a218d89
Compare
This PR/issue depends on:
|
a218d89
to
9999122
Compare
Closed
7a92758
to
fb7cd4d
Compare
dkoshkin
reviewed
Feb 21, 2024
dkoshkin
reviewed
Feb 21, 2024
dkoshkin
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some suggestions, but should merge this either way since these are super valuable! Thank you
21257e2
to
a1e5262
Compare
a1e5262
to
0f1a3f0
Compare
Merged
dkoshkin
referenced
this pull request
Mar 19, 2024
🤖 I have created a release *beep* *boop* --- ## 0.6.0 (2024-03-19) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Support HelmAddon strategy to deploy NFD by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/390 * feat: Upgrade AWS ESB CSI and switch to using Helm chart by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/393 * feat: CAPA 2.4.0 APIs and e2e by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/415 * feat: Single defaults namespace flag by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/426 * feat: add cluster-autoscaler CRS addon by @dkoshkin in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/423 * feat: add Cluster Autoscaler Addon with HelmAddon by @dkoshkin in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/427 * feat: NFD v0.15.2 by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/442 * feat: Include CABPK APIs by @dlipovetsky in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/445 ### Fixes 🔧 * fix: Ensure addons defaults namespaces are correctly wired up by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/409 * fix: Disable hubble in Cilium deployment via CRS by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/411 * fix: Fix Cilium helm values to use kubernetes IPAM by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/413 * fix: don't use an SSH key in AWS clusters by @dkoshkin in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/425 * fix: set default priorityClassName on Deployment by @dkoshkin in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/431 * fix: set default tolerations on Deployment by @dkoshkin in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/430 * fix: Remove vendored types for core CAPI providers (CAPD, CABPK, KCP) by @dlipovetsky in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/452 ### Other Changes * test: Add initial e2e tests by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/360 * test(e2e): Add CNI e2e tests by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/383 * test(e2e): Resolve latest upstream provider releases in e2e config by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/388 * test(e2e): Add test for NFD addon by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/389 * build: Ignore controller-runtime upgrades by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/403 * test(e2e): Use ghcr.io/mesosphere/kind-node for bootstrap by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/406 * build: Update AWS CPI manifest filenames by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/410 * revert: Temporarily disable GOPROXY to workaround dodgy CAPA release (#395) by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/407 * build: Ensure release namespace is use in kustomize helm inflator by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/412 * docs: Update menu ordering and add some icons by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/414 * test(e2e): Add AWS e2e tests by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/408 * build: clusterawsadm v2.4.0 by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/424 * docs: simplify running examples in README by @dkoshkin in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/422 * ci: Add dependabot for api module by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/432 * build: Fix up third-party CAPD go.mod CAPI dependency by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/441 * build: controller-runtime v0.17.2 by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/440 * ci: Fix up release workflow by specifying workflow-dispatch version by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/451 * docs: Update docsy module by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/455 * build: Rename module to d2iq-labs/cluster-api-runtime-extensions-nutanix by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/454 * test(e2e): Update test config with new repo name by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/457 * build: Reorg example kustomizations by @jimmidyson in https://github.com/d2iq-labs/cluster-api-runtime-extensions-nutanix/pull/453 **Full Changelog**: d2iq-labs/cluster-api-runtime-extensions-nutanix@v0.5.0...v0.6.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #361.
Added Docker e2e tests running using the CAPI e2e test utilities, clusters being created, waiting for all nodes to become ready, etc. tests include both Calico and Cilium deployed via both ClusterResourceSet and HelmAddon strategies. we can add more tests but this is a good start.
There is a data race in the test libraries which I don't know how to work around but it does not affect the usefulness of these tests and we can look at that later, unless someone knows what the problem is?Disabled race in ginkgo call, I think this is OK, it doesn't show races in deployed code only in tests.