docs: Update examples to be clusterctl templates #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/cluster-templates
branch
from
8534c9c to
2dbfe13
Compare
Provides easier integration with CAPI e2e testing libraries.
jimmidyson
force-pushed
the
jimmi/cluster-templates
branch
from
2dbfe13 to
a1aa75a
Compare
jimmidyson
force-pushed
the
jimmi/cluster-templates
branch
from
178f214 to
aa55a82
Compare
dkoshkin
reviewed
Feb 15, 2024
dkoshkin
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Tested the happy path in the docs manually, haven't tested it for the other examples but the e2e tests will catch any issues there.
➜ capi-runtime-extensions git:(jimmi/cluster-templates) ✗ kubectl --kubeconfig docker-kubeconfig get daemonsets -n kube-system cilium
NAME DESIRED CURRENT READY UP-TO-DATE AVAILABLE NODE SELECTOR AGE
cilium 2 2 2 2 2 kubernetes.io/os=linux 101s
Merged
dkoshkin
pushed a commit
that referenced
this pull request
Feb 15, 2024
🤖 I have created a release *beep* *boop* --- ## 0.4.2 (2024-02-15) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: remove word konvoy/ and use cre/ by @dkoshkin in #365 * fix: v2/ in Containerd mirror path by @dkoshkin in #363 * fix: set config_path in Containerd config by @dkoshkin in #364 * fix: generate config with only globalImageRegistryMirror set by @dkoshkin in #362 ### Other Changes * refactor: Fix formatting issue by @jimmidyson in #368 * build: Include CAPX APis by @jimmidyson in #367 * build: Upgrade golangci-lint to 1.56.1 by @jimmidyson in #369 * docs: Update examples to be clusterctl templates by @jimmidyson in #361 **Full Changelog**: v0.4.1...v0.4.2 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jimmidyson
added a commit
that referenced
this pull request
Feb 21, 2024
Blocked by #361. Added Docker e2e tests running using the CAPI e2e test utilities, clusters being created, waiting for all nodes to become ready, etc. tests include both Calico and Cilium deployed via both ClusterResourceSet and HelmAddon strategies. we can add more tests but this is a good start. ~There is a data race in the test libraries which I don't know how to work around but it does not affect the usefulness of these tests and we can look at that later, unless someone knows what the problem is?~ Disabled race in ginkgo call, I think this is OK, it doesn't show races in deployed code only in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides easier integration with CAPI e2e testing libraries.