Skip to content

Check authz request URI and non-URI params #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 7, 2024

Conversation

gerardsn
Copy link
Member

@gerardsn gerardsn commented May 3, 2024

No description provided.

@gerardsn gerardsn requested a review from reinkrul May 3, 2024 14:42
@gerardsn gerardsn mentioned this pull request May 3, 2024
@gerardsn gerardsn requested a review from reinkrul May 5, 2024 14:07
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could put the code blocks in separate private methods for readability.

Copy link
Member

@reinkrul reinkrul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this stuff is getting really hard to read

@gerardsn gerardsn force-pushed the feature/check-uri-and-non-uri-params branch from 57b483a to 37d7e18 Compare May 7, 2024 08:35
@gerardsn gerardsn merged commit a9ce5be into master May 7, 2024
@gerardsn gerardsn deleted the feature/check-uri-and-non-uri-params branch May 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants