Crypto: alter Storage interface to create keys inside key store #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardsn
approved these changes
May 21, 2024
reinkrul
force-pushed
the
crypto/support-unexportable-keys
branch
from
9a9df48 to
67a93c3
Compare
rolandgroen
added a commit
that referenced
this pull request
May 23, 2024
* refs/heads/master: (71 commits) Remove nonce from default Request Object params (#3125) Burn nonce type SessionStore entries after first use (#3123) Crypto: alter Storage interface to create keys inside key store (#3120) Crypto: let Exists() return an error if one occurs (#3127) Bump github.com/nats-io/nats-server/v2 from 2.10.14 to 2.10.15 (#3121) Bump github.com/nats-io/nats.go from 1.34.1 to 1.35.0 (#3122) Bump google.golang.org/grpc from 1.63.2 to 1.64.0 (#3119) Bump azure/setup-helm from 3.5 to 4 (#3050) cleanup oauth constants (#3117) prevent panic (#3118) Support request_uri_method=post (#3102) add GetAndDelete to SessionStore (#3116) bugfix: redirect browser instead of returning error when requested scope is unknown (3104) (#3113) SQL: Fix SQL Server e2e test connection strings (#3112) Docs: updated v6 release notes to include missing stuff (#3108) IAM: nil deref when re-using same user session (#3106) cleanup metadata (#3103) Docs: fixed MySql example DSN (#3110) Change tag in discovery service to simple lamport clock value (int) (#3098) e2e tests: have Nuts containers wait for DB container healthy (#3109) ... # Conflicts: # charts/nuts-node/values.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating one in application space, and then importing it into the key storage. This allows supporting unexportable keys, meaning keys that never leave the key store.
This is a preparation PR for supporting Azure Key Vault directly.
Kept the
SavePrivateKeyfunctionality since it's still used for migrating from one store to another.