Crypto: work on crypto.Signer instead of concrete private keys for signing #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
changed the title
reinkrul
changed the title
gerardsn
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially Crypto was set up to just act on
crypto.Signer, to support unexportable keys in a separate key vault at some point (meaning the private keys itself are never in the application memory, cryptographic operations are performed in the key vault). I tried implementing Azure Key Vault using this approach, but found that several functions act on the private key assuming it's always in-memory. This PR fixes that.Note that this only applies to signing, not to encryption: our encryption algorithm of choice (ECIES) isn't supported by Hashicorp Vault/Azure Key Vault. If encryption is a feature we want to retain in combination with secure key storage, RSA keys could be used instead.