Support for consolidation/robo:5.x #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronGilMartinez
force-pushed
the
OEL-3318
branch
from
5bbc3a0
to
3144dcc
Compare
drishu
suggested changes
Sep 26, 2024
Comment on lines
+11
to
+16
| PHP_VERSION: [ "8.2", "8.3" ] | ||
| include: | ||
| - ROBO_VERSION: "4.0" | ||
| PHP_VERSION: "8.0" | ||
| - ROBO_VERSION: "4.0" | ||
| PHP_VERSION: "8.1" |
There was a problem hiding this comment.
There is something wrong here, the PHP versions listed are 8.2 and 8.3 but you include lower versions in the matrix.
4.x supports min version php8.0 but the 5.x supports only php8.2 and up
There was a problem hiding this comment.
Indeed, Robo 4 and 5 supports different versions of PHP. What is configured here for the pipeline is:
- Execute PHP 8.2 and 8.3 for both Robo versions.
- For Robo 4.0 execute in addition PHP 8.0 and 8.1.
Example: https://github.com/AaronGilMartinez/robo-config/actions/runs/11018721272
composer.json
Outdated
| }, | ||
| "require-dev": { | ||
| "drupal/coder": "^8.3.16", | ||
| "phpunit/phpunit": "^9.5.5", | ||
| "phpro/grumphp": "^1.14" | ||
| "phpro/grumphp": "^1.14 || ^2.6" |
There was a problem hiding this comment.
what bring 2.6 that we need and 2.5 or lower does not?
There was a problem hiding this comment.
True, minimum is 2.3 that brings support for Symfony 7 and PHP 8.3, fixed.
drishu
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24
Link to tests https://github.com/AaronGilMartinez/robo-config/actions/