Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for consolidation/robo:5.x #26

Merged
merged 4 commits into from
Oct 3, 2024
Merged

Support for consolidation/robo:5.x #26

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2cca05
OEL-3318: Set broader constraints for composer, and update CI matrix.
AaronGilMartinez Sep 24, 2024
2aad611
OEL-3318: Set static methods for data providers.
AaronGilMartinez Sep 24, 2024
3144dcc
OEL-3318: Remove suffix.
AaronGilMartinez Sep 24, 2024
d7c5b5b
OEL-3318: Set minimum version for grumphp.
AaronGilMartinez Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,21 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
PHP_VERSION: [ "8.0", "8.1" ]
ROBO_VERSION: [ "4.0", "5.0" ]
PHP_VERSION: [ "8.2", "8.3" ]
include:
- ROBO_VERSION: "4.0"
PHP_VERSION: "8.0"
- ROBO_VERSION: "4.0"
PHP_VERSION: "8.1"
Comment on lines +11 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something wrong here, the PHP versions listed are 8.2 and 8.3 but you include lower versions in the matrix.
4.x supports min version php8.0 but the 5.x supports only php8.2 and up

Copy link
Contributor Author

@AaronGilMartinez AaronGilMartinez Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, Robo 4 and 5 supports different versions of PHP. What is configured here for the pipeline is:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it points to the wrong pipeline


steps:
- uses: actions/checkout@v2
- uses: php-actions/composer@v6
with:
php_version: ${{ matrix.php_version }}
command: "require consolidation/robo:~${{ matrix.ROBO_VERSION }}"
php_version: ${{ matrix.PHP_VERSION }}
version: 2
- uses: php-actions/phpunit@v3
with:
test_suffix: FALSE
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
}
],
"require": {
"consolidation/robo": "^4.0"
"consolidation/robo": "^4.0 || ^5.0"
},
"require-dev": {
"drupal/coder": "^8.3.16",
"phpunit/phpunit": "^9.5.5",
"phpro/grumphp": "^1.14"
"phpro/grumphp": "^1.14 || ^2.6"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what bring 2.6 that we need and 2.5 or lower does not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, minimum is 2.3 that brings support for Symfony 7 and PHP 8.3, fixed.

},
"autoload": {
"psr-4": {
Expand Down
6 changes: 3 additions & 3 deletions tests/TaskTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public function testProcess($config_file, $source_file, $processed_file) {
* @return array
* Test data.
*/
public function appendTestProvider() {
public static function appendTestProvider() {
return [
['1-config.yml', '1-input.php', '1-output-append.php'],
['2-config.yml', '2-input.php', '2-output-append.php'],
Expand All @@ -159,7 +159,7 @@ public function appendTestProvider() {
* @return array
* Test data.
*/
public function prependTestProvider() {
public static function prependTestProvider() {
return [
['1-config.yml', '1-input.php', '1-output-prepend.php'],
['2-config.yml', '2-input.php', '2-output-prepend.php'],
Expand All @@ -172,7 +172,7 @@ public function prependTestProvider() {
* @return array
* Test data.
*/
public function writeTestProvider() {
public static function writeTestProvider() {
return [
['3-config.yml', '3-output-write.php'],
];
Expand Down
Loading