Fix ANO linking warning #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cliffburdick can you review? |
| @@ -83,8 +83,10 @@ target_compile_options(advanced_network_rx PUBLIC ${DPDK_CFLAGS}) | |||
| target_compile_options(advanced_network_tx PUBLIC ${DPDK_CFLAGS}) | |||
|
|
|||
| target_link_libraries(advanced_network_common PUBLIC holoscan::core) | |||
| target_link_libraries(advanced_network_common PUBLIC -L${DPDK_LIBRARY_DIRS} ${DPDK_LIBRARIES} ${DPDK_EXTRA_LIBS}) | |||
| target_link_libraries(advanced_network_common PUBLIC -L${DOCA_LIBRARY_DIRS} -ldoca_gpunetio libdoca_gpunetio_device.a -ldoca_common -ldoca_argp -ldoca_eth -ldoca_flow) | |||
| target_link_directories(advanced_network_common PUBLIC ${DPDK_LIBRARY_DIRS}) | |||
There was a problem hiding this comment.
Can you just combine the DOCA and DPDK libs into a single line?
cliffburdick
requested changes
Aug 12, 2024
JohnMoon-VTS
force-pushed
the
cmake-ano-warning-fix
branch
from
929fb3e to
25862d1
Compare
|
@cliffburdick are we good to merge? |
Yes, sorry, just saw it was addressed. |
Can you approve the review? |
JohnMoon-VTS
force-pushed
the
cmake-ano-warning-fix
branch
from
d27f105 to
7383789
Compare
|
@cliffburdick, I went ahead and rebased - this should be ready for review. Thanks! |
cliffburdick
approved these changes
Aug 20, 2024
Currently, when building an app that uses the Advanced Network Operator (ANO), CMake throws some warnings: ``` CMake Warning at operators/advanced_network/CMakeLists.txt:87 (target_link_libraries): Target "<target>" requests linking to directory "/usr/lib/x86_64-linux-gnu". Targets may link only to libraries. CMake is dropping the item. ``` Like it says, there are directories being passed into target_link_libraries with -L which is not supported. Instead, let's use target_link_directories which is already being used in the ANO CMakeLists.txt file to pass those DPDK and DOCA directories. Signed-off-by: John Moon <john.moon@vts-i.com>
JohnMoon-VTS
force-pushed
the
cmake-ano-warning-fix
branch
from
7383789 to
cdb682e
Compare
|
@jjomier, I just rebased again. Anything else blocking merge? |
cliffburdick
approved these changes
Aug 26, 2024
sohamm17
pushed a commit
that referenced
this pull request
Sep 3, 2024
Currently, when building an app that uses the Advanced Network Operator (ANO), CMake throws some warnings: ``` CMake Warning at operators/advanced_network/CMakeLists.txt:87 (target_link_libraries): Target "<target>" requests linking to directory "/usr/lib/x86_64-linux-gnu". Targets may link only to libraries. CMake is dropping the item. ``` Like it says, there are directories being passed into target_link_libraries with -L which is not supported. Instead, let's use target_link_directories which is already being used in the ANO CMakeLists.txt file to pass those DPDK and DOCA directories. Signed-off-by: John Moon <john.moon@vts-i.com>
ronyrad
pushed a commit
to ronyrad/holohub
that referenced
this pull request
Nov 8, 2024
Currently, when building an app that uses the Advanced Network Operator (ANO), CMake throws some warnings: ``` CMake Warning at operators/advanced_network/CMakeLists.txt:87 (target_link_libraries): Target "<target>" requests linking to directory "/usr/lib/x86_64-linux-gnu". Targets may link only to libraries. CMake is dropping the item. ``` Like it says, there are directories being passed into target_link_libraries with -L which is not supported. Instead, let's use target_link_directories which is already being used in the ANO CMakeLists.txt file to pass those DPDK and DOCA directories. Signed-off-by: John Moon <john.moon@vts-i.com> Signed-off-by: Rony Rado <rrado@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when building an app that uses the Advanced Network Operator (ANO), CMake throws some warnings:
Like it says, there are directories being passed into target_link_libraries with -L which is not supported.
Instead, let's use target_link_directories which is already being used in the ANO CMakeLists.txt file to pass those DPDK and DOCA directories.