App: Fix Endoscopy Tool Tracking C++ Test Config #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where Endoscopy Tool Tracking C++ tests were relying on the default YAML configuration rather than the expected test configuration. 153bdfd updated the Endoscopy Tool Tracking C++ app CLI: - Under previous behavior a configuration path could be passed as the 0th positional argument - Under new behavior a configuration path may be passed as a keyword `--config` argument. This brings the C++ app CLI into closer alignment with the existing `--data` argument and with the Python app CLI. Prior to this fix, C++ test failures were observed: - The test config file was not properly passed to the app under the new CLI. Instead the default test config was used, which does not define a stop condition and led to test timeout. - The C++ render test failed due to relying on frame output from the test above. Reproduced previous test failures locally and verified tests pass with this fix applied. Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
tbirdso
force-pushed
the
endoscopy-test-fixes
branch
from
a05b73b to
317eb8e
Compare
jjomier
approved these changes
Aug 26, 2024
sohamm17
pushed a commit
that referenced
this pull request
Sep 3, 2024
Fixes issue where Endoscopy Tool Tracking C++ tests were relying on the default YAML configuration rather than the expected test configuration. 153bdfd updated the Endoscopy Tool Tracking C++ app CLI: - Under previous behavior a configuration path could be passed as the 0th positional argument - Under new behavior a configuration path may be passed as a keyword `--config` argument. This brings the C++ app CLI into closer alignment with the existing `--data` argument and with the Python app CLI. Prior to this fix, C++ test failures were observed: - The test config file was not properly passed to the app under the new CLI. Instead the default test config was used, which does not define a stop condition and led to test timeout. - The C++ render test failed due to relying on frame output from the test above. Reproduced previous test failures locally and verified tests pass with this fix applied. Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com>
ronyrad
pushed a commit
to ronyrad/holohub
that referenced
this pull request
Nov 8, 2024
Fixes issue where Endoscopy Tool Tracking C++ tests were relying on the default YAML configuration rather than the expected test configuration. 153bdfd updated the Endoscopy Tool Tracking C++ app CLI: - Under previous behavior a configuration path could be passed as the 0th positional argument - Under new behavior a configuration path may be passed as a keyword `--config` argument. This brings the C++ app CLI into closer alignment with the existing `--data` argument and with the Python app CLI. Prior to this fix, C++ test failures were observed: - The test config file was not properly passed to the app under the new CLI. Instead the default test config was used, which does not define a stop condition and led to test timeout. - The C++ render test failed due to relying on frame output from the test above. Reproduced previous test failures locally and verified tests pass with this fix applied. Signed-off-by: Tom Birdsong <tbirdsong@nvidia.com> Signed-off-by: Rony Rado <rrado@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where Endoscopy Tool Tracking C++ tests were relying on the default YAML configuration rather than the expected test configuration.
153bdfd updated the Endoscopy Tool Tracking C++ app CLI:
--configargument. This brings the C++ app CLI into closer alignment with the existing--dataargument and with the Python app CLI.Prior to this fix, C++ test failures were observed:
Reproduced previous test failures locally and verified tests pass with this fix applied.