Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for base16-vim alongside nvim-base16 #1006

Merged

Conversation

JamyGolden
Copy link
Contributor

@JamyGolden JamyGolden commented Apr 3, 2023

Currently lualine.nvim only supports nvim-base16, this adds support for base16-vim.

base16-vim and nvim-base16 both use the base16- prefix for colorscheme names:

This causes colorschemes from both plugins to trigger the lua/lualine/themes/base16.lua file, which is why I made the changes in that file.

  • Check if a base16-vim colorscheme is active (by testing to see if the first and last colour variables are set). If it is, use the existing global variables, if not then continue to load and setup nvim-base16.
  • Update readme in context of changes

I can add some more context for the base16-vim and tinted-theming if necessary, just let me know.

@titaniumtraveler
Copy link

Seems my PR (#1081) is a duplicate of this.
The tests seem to be fixed now and a simple rebase should merge those changes and rerun the tests.
Though I'm not sure if the maintainer are going to merge the oldish pull-requests.

@JamyGolden JamyGolden force-pushed the feature/support-for-base16-vim branch from 6aa5360 to 1ec3ea6 Compare January 29, 2024 12:36
@JamyGolden
Copy link
Contributor Author

Thanks for letting me know about updating the PR to run the tests. This PR has been here for a while without any engagement so I'm not sure if it will ever be merged. I really just want the functionality to be in lualine, so if you're able to get your PR merged, then go ahead! 😄

@titaniumtraveler
Copy link

I guess I will write an issue or something, in the mean time I just have been using a custom theme that basically does the same thing.

@JamyGolden JamyGolden force-pushed the feature/support-for-base16-vim branch from 1ec3ea6 to 1730e79 Compare March 27, 2024 21:37
@JamyGolden
Copy link
Contributor Author

@shadmansaleh any chance you can merge one of the PRs which add base16-vim support?

@shadmansaleh shadmansaleh merged commit 15d830d into nvim-lualine:master Apr 5, 2024
5 checks passed
@shadmansaleh
Copy link
Member

Thanks, @JamyGolden and @titaniumtraveler both of you for your contribution. Sorry, for responding so late. These PRs sort of got lost.

@titaniumtraveler
Copy link

@shadmansaleh No problem. I didn't really need to have that upstream, because I was essentially doing it as custom theme. But now I can just delete that code, which feels nice.
Also other people using lualine and base16-vim now just get builtin support, which is great!

@JamyGolden JamyGolden deleted the feature/support-for-base16-vim branch April 6, 2024 07:49
craigmac pushed a commit to craigmac/lualine.nvim that referenced this pull request May 15, 2024
titaniumtraveler added a commit to titaniumtraveler/config.nvim that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants