-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for base16-vim alongside nvim-base16 #1006
Add support for base16-vim alongside nvim-base16 #1006
Conversation
Seems my PR (#1081) is a duplicate of this. |
6aa5360
to
1ec3ea6
Compare
Thanks for letting me know about updating the PR to run the tests. This PR has been here for a while without any engagement so I'm not sure if it will ever be merged. I really just want the functionality to be in lualine, so if you're able to get your PR merged, then go ahead! 😄 |
I guess I will write an issue or something, in the mean time I just have been using a custom theme that basically does the same thing. |
1ec3ea6
to
1730e79
Compare
@shadmansaleh any chance you can merge one of the PRs which add base16-vim support? |
Thanks, @JamyGolden and @titaniumtraveler both of you for your contribution. Sorry, for responding so late. These PRs sort of got lost. |
@shadmansaleh No problem. I didn't really need to have that upstream, because I was essentially doing it as custom theme. But now I can just delete that code, which feels nice. |
Currently lualine.nvim only supports nvim-base16, this adds support for base16-vim.
base16-vim and nvim-base16 both use the
base16-
prefix for colorscheme names:This causes colorschemes from both plugins to trigger the
lua/lualine/themes/base16.lua
file, which is why I made the changes in that file.I can add some more context for the base16-vim and tinted-theming if necessary, just let me know.