-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Simplify our 0install vendor to remove unused features #11015
Conversation
3f00b1a
to
a2efa37
Compare
Note that this PR includes two commits that run ocamlformat on both the 0install-solver and the opam-0install codebases. Working with a formatted file is a lot easier. |
Thanks for getting started on this. To properly fork these projects and develop them as internal dune libraries, I suggest we take the following preliminary steps:
Once those 3 are done, the removal of dead code should commence as it will be a lot easier to tell what is being deleted. You followed the same steps but in a different order, which makes review a little bit harder. It's not a big deal though, as the changes are still simple. However, it would be helpful to push our changes after preliminary work |
Thanks for the pointers @rgrinberg, I'll work on cleaning up my butchery after stabilizing my changes, I have other ideas still Relatedly, my last commit pretty much solves #10987, although in a very opiniated way. |
0fb94be
to
0b4e4c6
Compare
0b4e4c6
to
c33ec38
Compare
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
…ate scripts Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
Signed-off-by: Ambre Austen Suhamy <ambre@tarides.com>
c33ec38
to
b2b825d
Compare
My above comment is now outdated, this PR is ready for review. The commit solving the weird errors is in another PR. |
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Our vendored dependency,
opam-0install
, is our only interface with0install
and doesn't usecommand
s or 'machine groups' at all. Here I remove them entirely, without any feature loss.The goal is to simplify the codebase such that future modifications are easier to make. In particular, looking at things like #10987, #10838, maybe even help with #10837.