Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cometbft): mitigate slow blocks due to inactive validators #1818

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

corverroos
Copy link
Collaborator

@corverroos corverroos commented Sep 5, 2024

Decreases default cometBFT consensus config param timeout_propose from 3s to 1s.

This aim to mitigate slow blocks when the proposing validator is offline/inactive. Currently, when 1 of 3 validators are offline, the block times on staging decreases from 1s to 4s.

I had a look at some other cosmos chains and aligning timeout_commit and timeout_propose seems to be common practice:

  • Sei: timeout_commit=200ms, timeout_propose=300s
  • Moonbridge and kopi: timeout_commit=1s, timeout_propose=1s

This change aims to mitigate the affect of offline validators on block times.

issue: #1812

@corverroos
Copy link
Collaborator Author

See block times slow down when 1of3 validators were offline in staging
image
image

@corverroos corverroos enabled auto-merge (squash) September 5, 2024 08:35
@corverroos corverroos merged commit eb00f04 into main Sep 5, 2024
18 of 19 checks passed
@corverroos corverroos deleted the corver/proposetimeout branch September 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants