Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cometbft): mitigate slow blocks due to inactive validators #1818

Merged
merged 1 commit into from
Sep 5, 2024
Merged

feat(cometbft): mitigate slow blocks due to inactive validators #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions halo/cmd/cometconfig.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ func DefaultCometConfig(homeDir string) cfg.Config {
conf.Mempool.Type = cfg.MempoolTypeNop // Disable cometBFT mempool
conf.ProxyApp = "" // Only support built-in ABCI app supported.
conf.ABCI = "" // Only support built-in ABCI app supported.
conf.Consensus.TimeoutPropose = time.Second // Mitigate slow blocks when proposer inactive (default=3s).

return *conf
}
Expand Down
2 changes: 1 addition & 1 deletion halo/cmd/testdata/TestRunCmd_defaults.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"Consensus": {
"RootDir": "./halo",
"WalPath": "data/cs.wal/wal",
"TimeoutPropose": 3000000000,
"TimeoutPropose": 1000000000,
"TimeoutProposeDelta": 500000000,
"TimeoutPrevote": 1000000000,
"TimeoutPrevoteDelta": 500000000,
Expand Down
2 changes: 1 addition & 1 deletion halo/cmd/testdata/TestRunCmd_flags.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"Consensus": {
"RootDir": "foo",
"WalPath": "data/cs.wal/wal",
"TimeoutPropose": 3000000000,
"TimeoutPropose": 1000000000,
"TimeoutProposeDelta": 500000000,
"TimeoutPrevote": 1000000000,
"TimeoutPrevoteDelta": 500000000,
Expand Down
2 changes: 1 addition & 1 deletion halo/cmd/testdata/TestRunCmd_json_files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
"Consensus": {
"RootDir": "testinput/input2",
"WalPath": "data/cs.wal/wal",
"TimeoutPropose": 3000000000,
"TimeoutPropose": 1000000000,
"TimeoutProposeDelta": 500000000,
"TimeoutPrevote": 1000000000,
"TimeoutPrevoteDelta": 500000000,
Expand Down
2 changes: 1 addition & 1 deletion halo/cmd/testdata/TestRunCmd_toml_files.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
"Consensus": {
"RootDir": "testinput/input1",
"WalPath": "data/cs.wal/wal",
"TimeoutPropose": 3000000000,
"TimeoutPropose": 1000000000,
"TimeoutProposeDelta": 500000000,
"TimeoutPrevote": 1000000000,
"TimeoutPrevoteDelta": 500000000,
Expand Down
Loading