wasm: close base64 encoder #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close the base64 encoder before returning the buffer. This ensures that all the bytes are written to the buffer. Without this, the last few bytes may be missing, resulting in a corrupted image. Usually, this would only corrupt the checksum, and the image would still be displayed fine. However, some applications do not like this (e.g., slack).
This was referenced Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close the base64 encoder before returning the buffer. This ensures that all the bytes are written to the buffer. Without this, the last few bytes may be missing, resulting in a corrupted image. Usually, this would only corrupt the checksum, and the image would still be displayed fine. However, some applications do not like this (e.g., slack).