Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release typescript #1773

Closed
wants to merge 22 commits into from
Closed

Release typescript #1773

wants to merge 22 commits into from

Conversation

nialexsan
Copy link
Contributor

@nialexsan nialexsan commented Sep 1, 2023

overtake #1728

nialexsan and others added 16 commits August 3, 2023 19:18
* switch to uuid from @onflow/utils-uid

* create tsconfigs

* typedefs in ts

* types for actor util

* types for address util

* Revert "switch to uuid from @onflow/utils-uid"

This reverts commit 2a15ef5.

* PKG -- [util-actor] converted to ts

* updated tsconfig

* fixed ts types generation

* Resolve circular dependency

* ts rlp

* change type location

* more types

* build types during regular build

* fix tests

* VSN -- [root] Changeset

* Merge remote-tracking branch 'origin/master' into nialexsan/add-types

* Revert "Resolve circular dependency"

This reverts commit 36efc7d.

* update lock

* VSN -- [root] changeset
Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address
* [WIP] Convert @onflow/types to TS

* stash

* kind of working

* fix package.json

* fix dictionary

* fix tests

* stash

* strong type tests

* remove any

* rename

* changeset
* PKG -- [util-actor] Enhance TS support

* rename handlerfnmap
@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2023

🦋 Changeset detected

Latest commit: 14b110e

The changes in this PR will be included in the next version bump.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nialexsan
Copy link
Contributor Author

nialexsan commented Sep 1, 2023

#1728 (comment)

Just flagging here: it doesn't appear that the jsdoc generated types are working on this branch anymore. So if this is released/merged into master at any point, one of the following 2 criteria must be met.

Typescript conversion is complete and no JSDoc types exist anymore (hopefully this is the case)
OR we fix the jsdoc types and have a mix of both jsdoc-generated and typescript types
otherwise this branch will introduce a regression in type definitions

jribbink and others added 3 commits September 8, 2023 12:52
* PKG -- [types] Simplify generics

* Fix array

* Fix Array
* PKG -- [config] Add TypeScript

* Changeset

* fixup

* Remove unnecessary generic from util-actor

* remove non null assertions

---------

Co-authored-by: Alex <12097569+nialexsan@users.noreply.github.com>
@JeffreyDoyle JeffreyDoyle mentioned this pull request Oct 20, 2023
4 tasks
@nialexsan
Copy link
Contributor Author

closed in favour of #1801 1801

@nialexsan nialexsan closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants