Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release typescript resolve conflict #1801

Merged
merged 17 commits into from
Nov 7, 2023

Conversation

nialexsan
Copy link
Contributor

@nialexsan nialexsan commented Nov 1, 2023

rebased #1773 with fixed merge conflicts

nialexsan and others added 8 commits November 1, 2023 16:04
* switch to uuid from @onflow/utils-uid

* create tsconfigs

* typedefs in ts

* types for actor util

* types for address util

* Revert "switch to uuid from @onflow/utils-uid"

This reverts commit 2a15ef5.

* PKG -- [util-actor] converted to ts

* updated tsconfig

* fixed ts types generation

* Resolve circular dependency

* ts rlp

* change type location

* more types

* build types during regular build

* fix tests

* VSN -- [root] Changeset

* Merge remote-tracking branch 'origin/master' into nialexsan/add-types

* Revert "Resolve circular dependency"

This reverts commit 36efc7d.

* update lock

* VSN -- [root] changeset
Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address
* [WIP] Convert @onflow/types to TS

* stash

* kind of working

* fix package.json

* fix dictionary

* fix tests

* stash

* strong type tests

* remove any

* rename

* changeset
* PKG -- [util-actor] Enhance TS support

* rename handlerfnmap
* PKG -- [types] Simplify generics

* Fix array

* Fix Array
* PKG -- [config] Add TypeScript

* Changeset

* fixup

* Remove unnecessary generic from util-actor

* remove non null assertions

---------

Co-authored-by: Alex <12097569+nialexsan@users.noreply.github.com>
Copy link

changeset-bot bot commented Nov 1, 2023

🦋 Changeset detected

Latest commit: 82d6206

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@onflow/fcl-bundle Minor
@onflow/types Minor
@onflow/util-encode-key Minor
@onflow/util-invariant Minor
@onflow/util-template Minor
@onflow/util-address Minor
@onflow/util-logger Minor
@onflow/util-uid Minor
@onflow/rlp Minor
@onflow/transport-grpc Minor
@onflow/transport-http Minor
@onflow/util-actor Minor
@onflow/typedefs Minor
@onflow/config Minor
@onflow/fcl-wc Major
@onflow/fcl Minor
@onflow/sdk Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nialexsan nialexsan force-pushed the release-typescript-resolve-conflict branch from fc9b28e to ac4e161 Compare November 1, 2023 20:36
@nialexsan nialexsan force-pushed the release-typescript-resolve-conflict branch from d99d69f to af2db93 Compare November 3, 2023 20:40
@nialexsan nialexsan marked this pull request as ready for review November 5, 2023 20:36
@nialexsan nialexsan requested a review from a team as a code owner November 5, 2023 20:36
@nialexsan nialexsan requested a review from jribbink November 5, 2023 20:59
@nialexsan nialexsan mentioned this pull request Nov 6, 2023
Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments regarding the changsets stuff, other than that LGTM

"@onflow/rlp": minor
---

Convert to Typescript
Copy link
Contributor

@jribbink jribbink Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably try to consolidate all of the changesets, there's a bunch floating around here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changesets should be consolidated to just one version bump, I think

@@ -1,5 +1,20 @@
# @onflow/config

## 1.2.0-typescript.0
Copy link
Contributor

@jribbink jribbink Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably remove all of the typescript tagged CHANGELOG changes in this branch

@nialexsan nialexsan merged commit 8881394 into master Nov 7, 2023
1 check passed
@nialexsan nialexsan deleted the release-typescript-resolve-conflict branch November 7, 2023 13:08
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants