-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release typescript resolve conflict #1801
Conversation
* switch to uuid from @onflow/utils-uid * create tsconfigs * typedefs in ts * types for actor util * types for address util * Revert "switch to uuid from @onflow/utils-uid" This reverts commit 2a15ef5. * PKG -- [util-actor] converted to ts * updated tsconfig * fixed ts types generation * Resolve circular dependency * ts rlp * change type location * more types * build types during regular build * fix tests * VSN -- [root] Changeset * Merge remote-tracking branch 'origin/master' into nialexsan/add-types * Revert "Resolve circular dependency" This reverts commit 36efc7d. * update lock * VSN -- [root] changeset
Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address
* [WIP] Convert @onflow/types to TS * stash * kind of working * fix package.json * fix dictionary * fix tests * stash * strong type tests * remove any * rename * changeset
* PKG -- [util-actor] Enhance TS support * rename handlerfnmap
* PKG -- [types] Simplify generics * Fix array * Fix Array
* PKG -- [config] Add TypeScript * Changeset * fixup * Remove unnecessary generic from util-actor * remove non null assertions --------- Co-authored-by: Alex <12097569+nialexsan@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 82d6206 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fc9b28e
to
ac4e161
Compare
d99d69f
to
af2db93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple comments regarding the changsets stuff, other than that LGTM
"@onflow/rlp": minor | ||
--- | ||
|
||
Convert to Typescript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably try to consolidate all of the changesets, there's a bunch floating around here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changesets should be consolidated to just one version bump, I think
packages/config/CHANGELOG.md
Outdated
@@ -1,5 +1,20 @@ | |||
# @onflow/config | |||
|
|||
## 1.2.0-typescript.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably remove all of the typescript tagged CHANGELOG changes in this branch
rebased #1773 with fixed merge conflicts