Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nialexsan/ts conversion fixed merge conflicts #1802

Merged
merged 38 commits into from
Nov 27, 2023

Conversation

nialexsan
Copy link
Contributor

@nialexsan nialexsan commented Nov 2, 2023

rebased #1758

nialexsan and others added 29 commits November 1, 2023 16:04
* switch to uuid from @onflow/utils-uid

* create tsconfigs

* typedefs in ts

* types for actor util

* types for address util

* Revert "switch to uuid from @onflow/utils-uid"

This reverts commit 2a15ef5.

* PKG -- [util-actor] converted to ts

* updated tsconfig

* fixed ts types generation

* Resolve circular dependency

* ts rlp

* change type location

* more types

* build types during regular build

* fix tests

* VSN -- [root] Changeset

* Merge remote-tracking branch 'origin/master' into nialexsan/add-types

* Revert "Resolve circular dependency"

This reverts commit 36efc7d.

* update lock

* VSN -- [root] changeset
Implements typescript support for: @onflow/rlp, @onflow/util-uid, @onflow/util-template, @onflow/util-logger, @onflow/util-invariant, @onflow/util-encode-key, @onflow/util-address
* [WIP] Convert @onflow/types to TS

* stash

* kind of working

* fix package.json

* fix dictionary

* fix tests

* stash

* strong type tests

* remove any

* rename

* changeset
* PKG -- [util-actor] Enhance TS support

* rename handlerfnmap
* PKG -- [types] Simplify generics

* Fix array

* Fix Array
* PKG -- [config] Add TypeScript

* Changeset

* fixup

* Remove unnecessary generic from util-actor

* remove non null assertions

---------

Co-authored-by: Alex <12097569+nialexsan@users.noreply.github.com>
Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: d6bab84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@onflow/transport-http Minor
@onflow/typedefs Minor
@onflow/types Minor
@onflow/fcl Minor
@onflow/sdk Minor
@onflow/fcl-wc Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from release-typescript-resolve-conflict to master November 7, 2023 13:08
@nialexsan nialexsan marked this pull request as ready for review November 8, 2023 21:34
@nialexsan nialexsan requested a review from a team as a code owner November 8, 2023 21:34
packages/sdk/readme.md Outdated Show resolved Hide resolved
packages/transport-http/src/send-http.ts Show resolved Hide resolved
packages/transport-http/src/send-http.ts Show resolved Hide resolved
packages/transport-http/src/send-ping.ts Show resolved Hide resolved
packages/typedefs/src/interaction.ts Show resolved Hide resolved
packages/typedefs/src/interaction.ts Show resolved Hide resolved
packages/typedefs/src/interaction.ts Outdated Show resolved Hide resolved
packages/typedefs/src/interaction.ts Outdated Show resolved Hide resolved
@nialexsan nialexsan requested a review from jribbink November 27, 2023 19:53
@nialexsan nialexsan force-pushed the nialexsan/ts-conversion-fixed-merge-conflicts branch from cab5a6e to 103a4ff Compare November 27, 2023 20:49
@jribbink jribbink merged commit 699303c into master Nov 27, 2023
1 check passed
@jribbink jribbink deleted the nialexsan/ts-conversion-fixed-merge-conflicts branch November 27, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants