[Access] Add arguments getter for data providers #6873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssageResponse with Arguments, updated unit tests
UlyanaAndrukhiv
requested review from
Guitarheroua,
AndriiDiachuk,
peterargue and
illia-malachyn
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6873 +/- ##
=======================================
Coverage 41.08% 41.09%
=======================================
Files 2119 2119
Lines 185893 185917 +24
=======================================
+ Hits 76383 76408 +25
+ Misses 103105 103096 -9
- Partials 6405 6413 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
….com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6865-data-provider-arguments
…of github.com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6865-data-provider-arguments
…age-id to avoid pendency on it
|
LGTM |
….com:The-K-R-O-K/flow-go into UlianaAndrukhiv/6865-data-provider-arguments
peterargue
reviewed
Jan 21, 2025
| @@ -483,8 +483,10 @@ func (s *WsControllerSuite) TestListSubscriptions() { | |||
|
|
|||
| id := uuid.New() | |||
| topic := dp.BlocksTopic | |||
| arguments := models.Arguments{} | |||
There was a problem hiding this comment.
can you add some value into the arguments map to ensure we're testing that the same set is returned in the asserts. Otherwise we could miss a bug where an empty argument set is passed instead
peterargue
reviewed
Jan 23, 2025
peterargue
reviewed
Jan 23, 2025
peterargue
approved these changes
Jan 23, 2025
|
@Guitarheroua can you review this one as well |
peterargue
reviewed
Jan 23, 2025
|
Looks good to me |
illia-malachyn
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6865
Context
This pull request adds a method
Argumentsto the data providers, allowing retrieval of stored initial request arguments. This method used by thelistOfSubscriptionto fill theArgumentsfield forListSubscriptionsMessageResponse.