-
Notifications
You must be signed in to change notification settings - Fork 192
[Access] Add arguments getter for data providers #6873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
peterargue
merged 18 commits into
onflow:master
from
The-K-R-O-K:UlianaAndrukhiv/6865-data-provider-arguments
Jan 24, 2025
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
cb2fa7d
Added arguments getter for data providers, filled ListSubscriptionsMe…
UlyanaAndrukhiv 0cd1186
Merge branch 'master' into UlianaAndrukhiv/6865-data-provider-arguments
UlyanaAndrukhiv acb6b02
Updatated TestListSubscriptions unit test
UlyanaAndrukhiv 33e3913
Merge branch 'UlianaAndrukhiv/6865-data-provider-arguments' of github…
UlyanaAndrukhiv 24fb036
Merge branch 'illia-malachyn/6845-unify-subscription-and-message-id' …
UlyanaAndrukhiv 0e3d1cf
Reverted changes from illia-malachyn/6845-unify-subscription-and-mess…
UlyanaAndrukhiv bacec03
Updated godoc
UlyanaAndrukhiv 4f23a22
Merge branch 'master' into UlianaAndrukhiv/6865-data-provider-arguments
UlyanaAndrukhiv b0c5ffa
Removed omitempty from ID and Topic for SubscriptionEntry
UlyanaAndrukhiv fe9f40b
Merge branch 'UlianaAndrukhiv/6865-data-provider-arguments' of github…
UlyanaAndrukhiv ca06def
Merge branch 'master' into UlianaAndrukhiv/6865-data-provider-arguments
UlyanaAndrukhiv 59ce14a
Merge branch 'master' of github.com:The-K-R-O-K/flow-go into UlianaAn…
Guitarheroua d89f7da
Merge branch 'master' into UlianaAndrukhiv/6865-data-provider-arguments
Guitarheroua d2e11f9
fixed remarks and tests
Guitarheroua 899b691
remove error_codes.go
Guitarheroua 93bb915
Apply suggestions from code review
peterargue a7f3163
Merge branch 'master' into UlianaAndrukhiv/6865-data-provider-arguments
peterargue 7413e02
Update engine/access/rest/websockets/models/subscription_entry.go
peterargue File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
engine/access/rest/websockets/data_providers/mock/data_provider.go
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some value into the arguments map to ensure we're testing that the same set is returned in the asserts. Otherwise we could miss a bug where an empty argument set is passed instead