Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock in "js" feature for uuid on wasm builds #54

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Lock in "js" feature for uuid on wasm builds #54

merged 1 commit into from
Feb 14, 2025

Conversation

mxgrey
Copy link
Contributor

@mxgrey mxgrey commented Feb 13, 2025

An update to uuid now requires the js feature to be explicitly enabled when targeting wasm. The latest version of bevy has fixed this upstream, but our main is still depending on bevy 0.12, which so far has not been updated.

There are two ways we can fix this for ourselves:

  1. Lock the version of uuid down to a known-good version, such as 1.4.1
  2. Lock the version of uuid up to 1.13.1 and then explicitly enable the js feature

I've opted for (2) so that we don't lose the benefit of whatever updates come into the uuid library over time.

I've already tested that these changes work for the web build of rmf_site_editor, although we will probably need to do a cargo update on the lockfile of the site editor.

Signed-off-by: Michael X. Grey <greyxmike@gmail.com>
@mxgrey mxgrey requested a review from koonpeng February 13, 2025 08:54
@mxgrey mxgrey merged commit e430c14 into main Feb 14, 2025
6 checks passed
@mxgrey mxgrey deleted the web_build branch February 14, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants