Lock in "js" feature for uuid on wasm builds #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to
uuid
now requires thejs
feature to be explicitly enabled when targeting wasm. The latest version of bevy has fixed this upstream, but ourmain
is still depending on bevy 0.12, which so far has not been updated.There are two ways we can fix this for ourselves:
uuid
down to a known-good version, such as 1.4.1uuid
up to 1.13.1 and then explicitly enable thejs
featureI've opted for (2) so that we don't lose the benefit of whatever updates come into the
uuid
library over time.I've already tested that these changes work for the web build of
rmf_site_editor
, although we will probably need to do acargo update
on the lockfile of the site editor.