Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the obstruction is related to a latching issue, allow resume #858

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Dec 8, 2023

What's new

  • Fix schedule change day, week, month view (revert to original design provided by library)
  • Allow resume if obstruction delivery alert is due to a latching problem
  • Sort option fields in task creation form, except for Cart IDs

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 766 lines in your changes are missing coverage. Please review.

Comparison is base (fe0e808) 49.35% compared to head (1010108) 26.78%.
Report is 38 commits behind head on deploy/hammer.

Files Patch % Lines
packages/dashboard/src/components/map-app.tsx 0.00% 171 Missing ⚠️
.../dashboard/src/components/delivery-alert-store.tsx 0.00% 100 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 68 Missing ⚠️
packages/react-components/lib/tasks/utils.ts 4.76% 54 Missing and 6 partials ⚠️
packages/dashboard/src/components/door-summary.tsx 0.00% 51 Missing ⚠️
packages/dashboard/src/components/lift-summary.tsx 0.00% 50 Missing ⚠️
...shboard/src/components/tasks/task-cancellation.tsx 0.00% 48 Missing ⚠️
...kages/dashboard/src/components/tasks/tasks-app.tsx 0.00% 47 Missing ⚠️
packages/react-components/lib/alert-dialog.tsx 6.66% 2 Missing and 12 partials ⚠️
...es/dashboard/src/components/tasks/task-summary.tsx 0.00% 12 Missing ⚠️
... and 25 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           deploy/hammer     #858       +/-   ##
==================================================
- Coverage          49.35%   26.78%   -22.57%     
==================================================
  Files                285      157      -128     
  Lines               7564     5201     -2363     
  Branches            1050     1365      +315     
==================================================
- Hits                3733     1393     -2340     
+ Misses              3682     3610       -72     
- Partials             149      198       +49     
Flag Coverage Δ
api-server ?
dashboard 13.95% <3.87%> (-1.12%) ⬇️
react-components 44.21% <15.87%> (-3.86%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review December 9, 2023 07:56
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth merged commit b6034a1 into deploy/hammer Dec 10, 2023
3 of 4 checks passed
@aaronchongth aaronchongth deleted the hammer/obs-latch-allow-resume branch December 10, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant